Closed
Bug 799462
Opened 12 years ago
Closed 12 years ago
GCLI jsb command should revert jsbBraceStyleDesc, jsbBraceStyleManual strings
Categories
(DevTools :: Console, defect)
DevTools
Console
Tracking
(firefox18 fixed)
RESOLVED
FIXED
Firefox 19
Tracking | Status | |
---|---|---|
firefox18 | --- | fixed |
People
(Reporter: jwalker, Assigned: miker)
References
Details
Attachments
(1 file)
(deleted),
patch
|
jwalker
:
review+
akeybl
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
It's my understanding that the UI will be not as nice as it could be, but not actually broken by this change.
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → mratcliffe
Assignee | ||
Comment 1•12 years ago
|
||
So, basically undoing these changes:
# LOCALIZATION NOTE (jsbBraceStyleDesc) A very short description of the
# 'jsb <braceStyle>' parameter. This string is designed to be shown
# in a menu alongside the command name, which is why it should be as short as
# possible.
-jsbBraceStyleDesc=Collapse, expand, end-expand, expand-strict
+jsbBraceStyleDesc=Select the coding style of braces
# LOCALIZATION NOTE (jsbBraceStyleManual) A fuller description of the
# 'jsb <braceStyle>' parameter, displayed when the user asks for help
# on what it does.
-jsbBraceStyleManual=The coding style of braces. Either collapse, expand, end-expand or expand-strict
+jsbBraceStyleManual=<p class="nowrap">The coding style of braces. Select from one of the following:</p><ul><li>collapse<br/><pre>if (x == 1) {\n ...\n} else {\n ...\n}</pre></li><li>expand<br/><pre>if (x == 1)\n{\n ...\n}\nelse\n{\n ...\n}</pre></li><li>end-expand<br/><pre>if (x == 1) {\n ...\n}\nelse {\n ...\n}</pre></li><li>expand-strict<br/><pre>if (x == 1)\n{\n return // This option can break scripts\n {\n a: 1\n };\n} else {\n ...\n}</pre></li></ul>
Assignee | ||
Comment 2•12 years ago
|
||
Attachment #669511 -
Flags: review?(jwalker)
Reporter | ||
Updated•12 years ago
|
Attachment #669511 -
Flags: review?(jwalker) → review+
Comment 4•12 years ago
|
||
Can we expidite the landing of this? And Alex, I support landing this on aurora.
Comment 5•12 years ago
|
||
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Comment 6•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 19
Assignee | ||
Comment 7•12 years ago
|
||
Comment on attachment 669511 [details] [diff] [review]
Reverted
[Approval Request Comment]
Bug caused by (feature/regressing bug #): String change
User impact if declined: None, but localizers will struggle to change the complex string (jsbBraceStyleManual)
Testing completed (on m-c, etc.): Yes
Risk to taking this patch (and alternatives if risky): Zero (string change)
String or UUID changes made by this patch: jsbBraceStyleDesc & jsbBraceStyleManual
Attachment #669511 -
Flags: approval-mozilla-aurora?
Comment 8•12 years ago
|
||
(In reply to Michael Ratcliffe [:miker] [:mratcliffe] from comment #7)
> String or UUID changes made by this patch: jsbBraceStyleDesc &
> jsbBraceStyleManual
In Axel's absence, including Stas to see if this is a desirable fix to pick up for Aurora.
Reporter | ||
Comment 9•12 years ago
|
||
(In reply to Alex Keybl [:akeybl] from comment #8)
> (In reply to Michael Ratcliffe [:miker] [:mratcliffe] from comment #7)
> > String or UUID changes made by this patch: jsbBraceStyleDesc &
> > jsbBraceStyleManual
>
> In Axel's absence, including Stas to see if this is a desirable fix to pick
> up for Aurora.
I take comment 4, to be support from Axel.
Comment 10•12 years ago
|
||
(In reply to Joe Walker [:jwalker] from comment #9)
> (In reply to Alex Keybl [:akeybl] from comment #8)
> > (In reply to Michael Ratcliffe [:miker] [:mratcliffe] from comment #7)
> > > String or UUID changes made by this patch: jsbBraceStyleDesc &
> > > jsbBraceStyleManual
> >
> > In Axel's absence, including Stas to see if this is a desirable fix to pick
> > up for Aurora.
>
> I take comment 4, to be support from Axel.
Ha fair enough. Missed that.
Updated•12 years ago
|
Attachment #669511 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 11•12 years ago
|
||
(In reply to Tim Taubert [:ttaubert] from comment #6)
> https://hg.mozilla.org/mozilla-central/rev/0759a7d8b78b
This patch has not changed l10n string names, so localizers will not notice change in l10n. Please, change string names. At least for aurora.
Reporter | ||
Comment 12•12 years ago
|
||
(In reply to Alexander L. Slovesnik from comment #11)
> (In reply to Tim Taubert [:ttaubert] from comment #6)
> > https://hg.mozilla.org/mozilla-central/rev/0759a7d8b78b
> This patch has not changed l10n string names, so localizers will not notice
> change in l10n. Please, change string names. At least for aurora.
The idea of this patch is to back out some late changes that didn't change string names. So this is a revert.
Comment 13•12 years ago
|
||
(In reply to Joe Walker [:jwalker] from comment #12)
> (In reply to Alexander L. Slovesnik from comment #11)
> > (In reply to Tim Taubert [:ttaubert] from comment #6)
> > > https://hg.mozilla.org/mozilla-central/rev/0759a7d8b78b
> > This patch has not changed l10n string names, so localizers will not notice
> > change in l10n. Please, change string names. At least for aurora.
>
> The idea of this patch is to back out some late changes that didn't change
> string names. So this is a revert.
Several locales has already translated these late changes - http://mxr.mozilla.org/l10n-mozilla-aurora/search?find=%2F&string=jsbBraceStyleManual%3D%3Cp+class%3D%22nowrap%22%3E
How are they gonna notice that these changes have been reverted?
Comment 14•12 years ago
|
||
Pushed to Aurora:
http://hg.mozilla.org/releases/mozilla-aurora/rev/a02e939d3088
status-firefox18:
--- → fixed
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•