in bug 795597 matti provides this pac file that isn't working for two reasons. function FindProxyForURL(url, host){ if (isResolvable("nonexistant.lan")) { return "DIRECT"; } else { alert(myIpAddress()); return "SOCKS5 127.0.0.1:8080"; } } the 769764 rewrite of pac file handling implemented proxyAlert() instead of alert(). alert() should be defined but proxyAlert() should not be for backwards compatibility.

Comment on attachment 669607 [details] [diff] [review] patch 0 heh oops. sorry for not catching that in the review

https://hg.mozilla.org/integration/mozilla-inbound/rev/cb9aa35ad1ca

Comment on attachment 669607 [details] [diff] [review] patch 0 [Approval Request Comment] Bug caused by (feature/regressing bug #): jank killing proxy rewrite 769764 User impact if declined: pac files using diag function alert() will fail to operate Testing completed (on m-c, etc.): manual Risk to taking this patch (and alternatives if risky): very low risk.. it just changes a function name from proxyAlert to alert to maintain backwards compat String or UUID changes made by this patch: none

https://hg.mozilla.org/mozilla-central/rev/cb9aa35ad1ca Should this have a test?

(In reply to Patrick McManus [:mcmanus] from comment #4) > Comment on attachment 669607 [details] [diff] [review] > patch 0 > > [Approval Request Comment] > Bug caused by (feature/regressing bug #): jank killing proxy rewrite 769764 > User impact if declined: pac files using diag function alert() will fail to > operate What's a pac file and who uses them.

(In reply to Alex Keybl [:akeybl] from comment #6) > > > What's a pac file and who uses them. pac - proxy auto config http://en.wikipedia.org/wiki/Proxy_auto-config Amongst proxy users, its a pretty common way of defining the proxy and when to use it. Our default windows configuration will use it if the LAN administrator has set things up that way.