Closed
Bug 799547
Opened 12 years ago
Closed 12 years ago
Network stats landing in dom/network broke MozTCPSocket when MOZ_B2G_RIL is defined (like on Otoro devies) by clobbering EXTRA_COMPONENTS in Makefile.in
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla19
Tracking | Status | |
---|---|---|
firefox18 | --- | fixed |
People
(Reporter: asuth, Assigned: asuth)
References
Details
Attachments
(1 file)
(deleted),
patch
|
asuth
:
review+
|
Details | Diff | Splinter Review |
The change of = to += to fix things is rs=jdm
Attachment #669602 -
Flags: review+
Assignee | ||
Comment 1•12 years ago
|
||
Landed on inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8f844ca34b7f
Assignee | ||
Updated•12 years ago
|
Comment 2•12 years ago
|
||
Ouch. Nice catch.. do you know if we have any MozTCPSocket tests running in TBPL?
Comment 3•12 years ago
|
||
Not under the RIL configuration, I presume, since I don't think the b2g builds run any tests.
Assignee | ||
Comment 4•12 years ago
|
||
Comment on attachment 669602 [details] [diff] [review]
Change = to += to not clobber MozTCPSocket
[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 746069
User impact if declined: B2G Gaia e-mail app won't be able to speak IMAP or SMTP on actual phones (b2g-desktop is fine because RIL is not built)
Testing completed (on m-c, etc.): Landed on inbound, not on mozilla-central yet. Requesting approval early because the fix is a single "+" in a Makefile and it would be nice to get IMAP/SMTP in tonight's b2g nightly now that b2g nightlies have switched to Aurora.
Risk to taking this patch (and alternatives if risky): No risk. It's a very obvious Makefile fix.
String or UUID changes made by this patch: None.
Attachment #669602 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 5•12 years ago
|
||
Comment on attachment 669602 [details] [diff] [review]
Change = to += to not clobber MozTCPSocket
Oops, because this is the actual fix for bug 798740 which is a blocker (and this bug just exists for hygiene), I can land this on aurora per https://wiki.mozilla.org/Tree_Rules/B2G, clearing approval request.
Attachment #669602 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 6•12 years ago
|
||
landed on aurora:
https://hg.mozilla.org/releases/mozilla-aurora/rev/c81cbb2cd989
status-firefox-esr17:
--- → fixed
Comment 7•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Assignee | ||
Updated•12 years ago
|
status-firefox18:
--- → fixed
status-firefox-esr17:
fixed → ---
Updated•12 years ago
|
Component: DOM: Mozilla Extensions → DOM
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•