Closed
Bug 800044
Opened 12 years ago
Closed 12 years ago
Hide private browsing menu item
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox19 verified)
VERIFIED
FIXED
Firefox 19
| Tracking | Status | |
|---|---|---|
| firefox19 | --- | verified |
People
(Reporter: bnicholson, Assigned: bnicholson)
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
Bug 582244 was landed, but there's still lots of open dependencies for private browsing before it can be considered usable (bug 794502). This patch disables the menu item by default and adds a "browser.ui.privatebrowsing.enabled" pref.
Attachment #670041 -
Flags: review?(mark.finkle)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 670041 [details] [diff] [review]
Disable private browsing menu item by default
Review of attachment 670041 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks for the patch, Brian!
|
||
Comment 2•12 years ago
|
||
Comment on attachment 670041 [details] [diff] [review]
Disable private browsing menu item by default
Let's just simplify this patch to always hide the menu. We have enough work to do, so just hide the menu in the XML.
I suggested this approach, but now I think it's overkill.
Attachment #670041 -
Flags: review?(mark.finkle) → review-
|
Assignee | |
Comment 3•12 years ago
|
||
Attachment #670041 -
Attachment is obsolete: true
Attachment #670564 -
Flags: review?(mark.finkle)
|
|
||
Updated•12 years ago
|
Attachment #670564 -
Flags: review?(mark.finkle) → review+
|
|
Assignee | |
Updated•12 years ago
|
Summary: Disable private browsing menu item by default → Hide private browsing menu item
|
|
Assignee | |
Comment 4•12 years ago
|
||
|
||
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
|
||
Updated•12 years ago
|
Status: RESOLVED → VERIFIED
status-firefox19:
--- → verified
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•