Closed
Bug 800688
Opened 12 years ago
Closed 12 years ago
local_dynamic_payload_type_value set and not used in gsm_sdp.c
Categories
(Core :: WebRTC: Signaling, defect, P3)
Core
WebRTC: Signaling
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: jesup, Assigned: emannion)
References
Details
(Whiteboard: [WebRTC], [blocking-webrtc-] [qa-])
Attachments
(1 file)
(deleted),
patch
|
ehugg
:
review+
|
Details | Diff | Splinter Review |
media/webrtc/signaling/src/sipcc/core/gsm/gsm_sdp.c
Location: line 2834
local_dynamic_payload_type_value in gsmsdp_negotiate_codec() is set, but never used. Likely this is a real bug, but not sure without analysis exactly what should be done.
Reporter | ||
Comment 1•12 years ago
|
||
The other places it's set in there are dead assignments also
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → emannion
Assignee | ||
Comment 2•12 years ago
|
||
I removed this unused lines from negotiation, I would like crypt to confirm that this is not breaking anything especially especially how negotiation worked when using SIP. The unit tests are completing sucessfully.
Attachment #672308 -
Flags: review?(snandaku)
Attachment #672308 -
Flags: review?(ethanhugg)
Updated•12 years ago
|
Priority: -- → P3
Whiteboard: [WebRTC], [blocking-webrtc-]
Updated•12 years ago
|
Attachment #672308 -
Flags: review?(ethanhugg) → review+
Comment 3•12 years ago
|
||
Comment on attachment 672308 [details] [diff] [review]
remove local_dynamic_payload_type_value from
This looks like just removal of unused code.
Attachment #672308 -
Flags: review?(snandaku) → checkin?(rjesup)
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Updated•12 years ago
|
Attachment #672308 -
Flags: checkin?(rjesup)
Updated•12 years ago
|
Whiteboard: [WebRTC], [blocking-webrtc-] → [WebRTC], [blocking-webrtc-] [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•