Dominic Kuo [:dkuo] Reporter
	Description • 12 years ago

1. We sort the songs in mix page by added date (recently added) only, we should also consider the recently played and highest rated songs.

2. Maybe we can just show a constant amount, like 18, 24 or 30 (multiples of 6 cause one mix group contains 6 songs) instead of displaying all the songs in device.

3. If the above logics result in an amount which is not a multiple of 6, we better fix it or we might see a mix group that is not completed.

	Mike Connor [:mconnor]
	Comment 1 • 12 years ago

Per triage: this is not a blocker, as it's basically tweaking to an existing feature. If UX or Product want to make a case for why we must fix this for v1, we'll reconsider.

	Patryk Adamczyk [:patryk] UX
	Comment 3 • 12 years ago

(In reply to Mike Connor [:mconnor] from comment #1)
> Per triage: this is not a blocker, as it's basically tweaking to an existing
> feature. If UX or Product want to make a case for why we must fix this for
> v1, we'll reconsider.

The spec stated the mix filter would have logic applied to it. It would display tracks based on the logic described here: https://www.dropbox.com/s/v1vuno1688gmy4q/B2g-music-v4.pdf on pg.2.

So yes the feature has been implemented visually, but not with the logic to spec, so I wouldn't call it a tweak.

	Patryk Adamczyk [:patryk] UX
	Comment 4 • 12 years ago

(In reply to Dominic Kuo [:dkuo] from comment #0)
> 1. We sort the songs in mix page by added date (recently added) only, we
> should also consider the recently played and highest rated songs.
> 
> 2. Maybe we can just show a constant amount, like 18, 24 or 30 (multiples of
> 6 cause one mix group contains 6 songs) instead of displaying all the songs
> in device.
> 
> 3. If the above logics result in an amount which is not a multiple of 6, we
> better fix it or we might see a mix group that is not completed.

1. For the recently added... I would show albums instead of songs, since you'll see more content on the screen, and won't be flooded with the same album art. Recently played and highest rated would be songs.
2. I don't think we'd want to show more than 18 tracks.
3. We can probably get away with multiples of 3.

	Parul Mathur
	Comment 5 • 12 years ago

As per Dominic's email on Sun, 23 Dec 2012 19:26:12 -0800 (PST) "Currently Music app just list all the albums in Mix page in ascending order." 
I added about 413 music files in 50 albums at the same time to my SD Card. The Mix Page I see does not sort by albums alphabetically. (See screenshots attached). The logic of the Mix Page is still not clear.

	Parul Mathur
	Comment 6 • 12 years ago

Screenshot of Mix Page - 1

	Parul Mathur
	Comment 7 • 12 years ago

Screenshot of Mix Page - 2

	Dominic Kuo [:dkuo] Reporter
	Comment 9 • 12 years ago

Looks like everyone is confused with the mix page...nominating this.

	Dietrich Ayala (:dietrich)
	Comment 10 • 12 years ago

Didn't block before, and not blocking now. While this page can be improved, it does not impair any critical functionality. Blocking-.

	Cody Roesch [:croesch]
	Comment 12 • 12 years ago

Build ID: 20130130070201
Kernel: Dec 5
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/4593f3e765eb
Gaia   f7f5a0cd17e3d04308cc5850b254947e127122b9

In testrun 4 this bug fails case
https://moztrap.mozilla.org/runtests/run/712/env/296/?pagenumber=1&pagesize=100&sortfield=order&sortdirection=asc&filter-id=3752&filter-suite=124

UCID music-002

	Eric Pang [:epang] UX
	Comment 13 • 12 years ago

Hey Dominic, what's the status of this bug? Is there anything you need from anyone to work on this?

	Lukas Blakk [:lsblakk] use ?needinfo
	Comment 14 • 12 years ago

Mass edit to set tracking-b2g18+ for these UX bugs that were called out for v1.1

	Dominic Kuo [:dkuo] Reporter
	Comment 15 • 12 years ago

(In reply to Eric Pang [:epang] from comment #13)
> Hey Dominic, what's the status of this bug? Is there anything you need from
> anyone to work on this?

Eric, sorry for the late reply, I will start to implement this bug tomorrow, I think I got enough info to fix this issue, thanks.

	Eric Pang [:epang] UX
	Comment 16 • 12 years ago

(In reply to Dominic Kuo [:dkuo] from comment #15)
> (In reply to Eric Pang [:epang] from comment #13)
> > Hey Dominic, what's the status of this bug? Is there anything you need from
> > anyone to work on this?
> 
> Eric, sorry for the late reply, I will start to implement this bug tomorrow,
> I think I got enough info to fix this issue, thanks.

Thanks Dominic!

	Dominic Kuo [:dkuo] Reporter
	Comment 17 • 12 years ago

Eric,

I haven't finish my patch yet and things are harder than I thought, I still need more works to complete it, and there are some details I need to discuss with ux. Also I need to switch my tasks between leo+ bgus and this one, but I will fix this parallel. I will send you a email to start the offline discuss, thanks.

	Eric Pang [:epang] UX
	Comment 18 • 12 years ago

No Problem, I really appreciated what you've done already!

	John Hammink
	Comment 19 • 11 years ago

I'd like to suggest this as a feature for koi - particularly as Dominic is already on track with the work.  Certainly Parul's work, starting in Comment #5, illustrates the need for a fix.  Nomming for koi?

	Hema Koka [:hema]
	Comment 20 • 11 years ago

Sri, As discussed in the triage meeting. This is perhaps included in the mix page redesign user story that we have in the media backlog. Please confirm

	Sri Kasetti
	Comment 21 • 11 years ago

Hema, Yeah this is the bug we are tracking in the product backlog

	Hema Koka [:hema]
	Comment 22 • 11 years ago

Adding this to the backlog (not blocking for 1.3)

	Hema Koka [:hema]
	Comment 25 • 10 years ago

Rob/Jacqueline,

As we are working through migrating music based on the new architecture, wondering if we need to make any changes to the mix page logic (I know we talked about even getting rid of this page and replacing with a useful landing page ). Let us know your input. 

Thanks
Hema

	Jacqueline Savory [:jsavory] UX
	Comment 26 • 9 years ago

Hi Hema,

If possible, we could change the mix page to the home page I have in the music redesign spec:
https://mozilla.box.com/s/8k4u7pjmoimosocfzzu6

This screen is essentially the preset playlists listed at the top of the screen with user generated ones at the bottom. For now we could simply not display the user generated ones. Also, this would reduce the number of icons in the toolbar from 5 to 4 as we could remove the mix page icon. 

Let me know if this makes sense or if you have any questions. Thanks!

	Jim Porter (:squib)
	Comment 27 • 9 years ago

Per comment 26, the mix page is going away, to be replaced by an enhanced version of the playlists page. Closing this.