Closed
Bug 8009
Opened 25 years ago
Closed 24 years ago
editor/base/*Txn.cpp hard-coded strings (not in UI)
Categories
(Core :: DOM: Editor, defect, P3)
Core
DOM: Editor
Tracking
()
VERIFIED
FIXED
Future
People
(Reporter: Brade, Assigned: kinmoz)
References
Details
(Keywords: helpwanted)
in ChangeAttributeTxn.cpp
ChangeAttributeTxn::GetUndoString and ChangeAttributeTxn::GetRedoString have
hard-coded strings in them. These will need to be pulled out for L10n efforts.
Reporter | ||
Updated•25 years ago
|
Summary: [L10N] ChangeAttributeTxn.cpp hard-coded UI strings → [L10N] editor/base/*Txn.cpp hard-coded UI strings
Reporter | ||
Comment 1•25 years ago
|
||
Also...
file methods
CreateElementTxn.cpp GetUndoString, GetRedoString
DeleteTextTxn.cpp GetUndoString, GetRedoString
DeleteElementTxn.cpp GetUndoString, GetRedoString
DeleteRangeTxn.cpp GetUndoString, GetRedoString
InsertTextTxn.cpp GetUndoString, GetRedoString
JoinElementTxn.cpp GetUndoString, GetRedoString
SplitElementTxn.cpp GetUndoString, GetRedoString
Reporter | ||
Updated•25 years ago
|
Assignee: buster → brade
Reporter | ||
Updated•25 years ago
|
Status: NEW → ASSIGNED
Target Milestone: M8
Reporter | ||
Comment 2•25 years ago
|
||
reassign to myself; cc bobj@netscape.com
I assume these are error messages that you need to resource?
Check out: http://www.mozilla.org/projects/intl/string-resources.html
Cc'ing Tao and Erik who can help with the strres APIs.
Can wait until M10. We have very few places where we have embedded strings, so
I'm not concerned about leaving this until after we've hit full functionality.
These are strings that can be made available to the UI to give more meaning to
the user about what action will be undone|redone.
Of course, sooner is better. The L10N engineers have already begun creating
pseudo-localizations to test localizability where possible.
Of course, sooner is better. The L10N engineers have already begun creating
pseudo-localizations to test localizability where possible.
Of course, sooner is better. The L10N engineers have already begun creating
pseudo-localizations to test localizability where possible.
Reporter | ||
Updated•25 years ago
|
QA Contact: sujay → tao
Reporter | ||
Comment 8•25 years ago
|
||
changing contact person to tao@netscape.com
Reporter | ||
Updated•25 years ago
|
Target Milestone: M8 → M9
Reporter | ||
Comment 9•25 years ago
|
||
moving to M9
Updated•25 years ago
|
Whiteboard: kathy, have a fix in hand?
Reporter | ||
Updated•25 years ago
|
Target Milestone: M9 → M10
Reporter | ||
Comment 10•25 years ago
|
||
M10
Reporter | ||
Updated•25 years ago
|
Whiteboard: kathy, have a fix in hand?
Target Milestone: M10 → M11
Reporter | ||
Comment 11•25 years ago
|
||
m11
Reporter | ||
Updated•25 years ago
|
Target Milestone: M11 → M12
Reporter | ||
Comment 12•25 years ago
|
||
infrastructure in place; move to M12 (note: only logging currently uses the hard-
coded strings)
Updated•25 years ago
|
Summary: [L10N] editor/base/*Txn.cpp hard-coded UI strings → [BETA][L10N] editor/base/*Txn.cpp hard-coded UI strings
Whiteboard: [BETA code cleanup]
Target Milestone: M12 → M14
Comment 13•25 years ago
|
||
setting to M14, this can wait till after dogfood
Comment 14•25 years ago
|
||
Beth, this needs to be fixed before M14 because we are localizing M14. Can you
set the milestone to M13? I agree it's not dogfood, but early M13 is our
deadline for translation. Thanks!
Updated•25 years ago
|
Whiteboard: [BETA code cleanup] → [PRE-BETA]
Comment 15•25 years ago
|
||
removing whiteboard summary text
Summary: [BETA][L10N] editor/base/*Txn.cpp hard-coded UI strings → [L10N] editor/base/*Txn.cpp hard-coded UI strings
Whiteboard: [PRE-BETA]
Updated•25 years ago
|
Whiteboard: [pdt+]
Reporter | ||
Comment 17•25 years ago
|
||
I would like this bug reconsidered and marked PDT-
Removing PDT+ on status whiteboard so it will be reconsidered.
These strings are only used in the logging system which is a "debug" thing; they
don't appear anywhere in the UI.
This bug could be fixed in 3 ways:
* remove the strings altogether and break logging
* create a properties file and write extra code to handle these strings
(temporarily)
* the "right" way which is dependent on command-dispatching which may not be
completely in place for beta1 (bug #18395 I think)
Depends on: 18395
Whiteboard: [pdt+]
Reporter | ||
Comment 19•25 years ago
|
||
moving to M15 (hopefully Simon's / Hyatt's stuff will be done by then)
Target Milestone: M14 → M15
Reporter | ||
Comment 20•25 years ago
|
||
remove beta1 keyword and PDT- status whiteboard
Keywords: beta1
Whiteboard: [PDT-]
Reporter | ||
Updated•25 years ago
|
Summary: [L10N] editor/base/*Txn.cpp hard-coded UI strings → editor/base/*Txn.cpp hard-coded strings (not in UI)
Target Milestone: M15 → M16
Reporter | ||
Updated•25 years ago
|
Target Milestone: M16 → M17
Assignee | ||
Comment 23•24 years ago
|
||
Taking this off of brade's plate.
Assignee: brade → kin
Status: ASSIGNED → NEW
Assignee | ||
Comment 24•24 years ago
|
||
The GetUndoString() and GetRedoString() methods were ripped out when I landed
changes for bug #66308, so this bug is effectively fixed. ;-)
The only strings left in the transactions are left for logging/debugging which
will never appear in the UI, so they don't need translating.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Comment 25•24 years ago
|
||
Kin/Kathy, can you verify this one and mark VERIFIED-FIXED ? thx.
You need to log in
before you can comment on or make changes to this bug.
Description
•