Bug 722978 was filed for desktop, but Firefox on Android uses a tab-based private browing pattern. The patch in bug 722978 is for window-based private browsing and won't work for mobile. Maybe we should pass the browser.contentWindow into the addPermanentException and addTemporaryException methods so we can check the specific content docshell flags.

(In reply to Mark Finkle (:mfinkle) from comment #0) > Bug 722978 was filed for desktop, but Firefox on Android uses a tab-based > private browing pattern. The patch in bug 722978 is for window-based private > browsing and won't work for mobile. > > Maybe we should pass the browser.contentWindow into the > addPermanentException and addTemporaryException methods so we can check the > specific content docshell flags. Is that code used in mobile directly? My patch in bug 722978 is using the |window| object, which is the global window object of exceptionDialog.xul, and if the window object in mobile is something similar to that, it should work for mobile as well.

(In reply to Ehsan Akhgari [:ehsan] from comment #1) > (In reply to Mark Finkle (:mfinkle) from comment #0) > > Bug 722978 was filed for desktop, but Firefox on Android uses a tab-based > > private browing pattern. The patch in bug 722978 is for window-based private > > browsing and won't work for mobile. > > > > Maybe we should pass the browser.contentWindow into the > > addPermanentException and addTemporaryException methods so we can check the > > specific content docshell flags. > > Is that code used in mobile directly? My patch in bug 722978 is using the > |window| object, which is the global window object of exceptionDialog.xul, > and if the window object in mobile is something similar to that, it should > work for mobile as well. Mobile uses in-content error pages and does _not_ use a dialog for any part of the UI. That's the core reason we forked the code. Since it's all in-content (and per-tab) I think we need to use the browser.contentWindow to check the private browsing flags.

(In reply to comment #2) > (In reply to Ehsan Akhgari [:ehsan] from comment #1) > > (In reply to Mark Finkle (:mfinkle) from comment #0) > > > Bug 722978 was filed for desktop, but Firefox on Android uses a tab-based > > > private browing pattern. The patch in bug 722978 is for window-based private > > > browsing and won't work for mobile. > > > > > > Maybe we should pass the browser.contentWindow into the > > > addPermanentException and addTemporaryException methods so we can check the > > > specific content docshell flags. > > > > Is that code used in mobile directly? My patch in bug 722978 is using the > > |window| object, which is the global window object of exceptionDialog.xul, > > and if the window object in mobile is something similar to that, it should > > work for mobile as well. > > Mobile uses in-content error pages and does _not_ use a dialog for any part of > the UI. That's the core reason we forked the code. Since it's all in-content > (and per-tab) I think we need to use the browser.contentWindow to check the > private browsing flags. Yeah that should work.

This patch passes the browser window to the exception tracking code and uses it to determine if the browser is private. It uses PrivateBrowsingUtils.

This patch does some simple cleanup in the JS file.

https://hg.mozilla.org/integration/mozilla-inbound/rev/a1170e62ccd5 https://hg.mozilla.org/integration/mozilla-inbound/rev/f2686a2cd826

https://hg.mozilla.org/mozilla-central/rev/a1170e62ccd5 https://hg.mozilla.org/mozilla-central/rev/f2686a2cd826