Boris Zbarsky [:bzbarsky] Assignee
	Description • 12 years ago

      No description provided.

	:Ms2ger (he/him; ⌚ UTC+1/+2)
	Comment 4 • 12 years ago

Comment on attachment 671490 [details] [diff] [review]
part 2.  Switch ImageData to WebIDL bindings.

Review of attachment 671490 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/xpconnect/src/dom_quickstubs.qsconf
@@ -963,5 @@
>          'unwrapThisFailureFatal' : False
> -        },
> -    'nsIDOMImageData_GetWidth': {
> -        'thisType': 'nsIDOMImageData',
> -        'code': 'uint32_t result = static_cast<mozilla::dom::ImageData*>(self)->GetWidth();',

This code is busted between part 1 and 2?

	Boris Zbarsky [:bzbarsky] Assignee
	Comment 5 • 12 years ago

> This code is busted between part 1 and 2?

Er, yes.  I'll add a bit to part 1 to fix that.

	Boris Zbarsky [:bzbarsky] Assignee
	Comment 7 • 12 years ago

Note to self: this causes a single test failure due to bug 742191 because unwrapping WebIDL objects don't throw a TypeError yet.

	Peter Van der Beken [:peterv]
	Comment 8 • 12 years ago

Comment on attachment 671639 [details] [diff] [review]
Part 2 with the imagedata classinfo really gone

Review of attachment 671639 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsJSEnvironment.cpp
@@ +3838,5 @@
> +
> +  // Write the internals to the stream.
> +  return JS_WriteUint32Pair(writer, SCTAG_DOM_IMAGEDATA, 0) &&
> +    JS_WriteUint32Pair(writer, width, height) &&
> +    JS_WriteTypedArray(writer, dataArray);

Keep the JS_* lined up.

	Boris Zbarsky [:bzbarsky] Assignee
	Comment 9 • 12 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/c97738963229
https://hg.mozilla.org/integration/mozilla-inbound/rev/c8ad798b2ced
https://hg.mozilla.org/integration/mozilla-inbound/rev/982da0cd2711

	Ryan VanderMeulen [:RyanVM]
	Comment 10 • 12 years ago

https://hg.mozilla.org/mozilla-central/rev/c97738963229
https://hg.mozilla.org/mozilla-central/rev/c8ad798b2ced
https://hg.mozilla.org/mozilla-central/rev/982da0cd2711