xlib, solaris7sparc, morning cvs build +2patches [79213:33663,79174:33389] x-win32, i'm building w/ --enable-optimize I tried to copy the url from bug 78972 into the url bar. WEBSHELL+ = 3 Creating a new nsIToolkit! Enabling Quirk StyleSheet ###!!! ASSERTION: already initialized: '!sWidget', file /tmp/mozilla/widget/src/xlib/nsClipboard.cpp, line 92 ###!!! Break: at file /tmp/mozilla/widget/src/xlib/nsClipboard.cpp, line 92 Creating a new nsIToolkit! [New LWP 10 ] ###!!! ASSERTION: nsImageXlib::DrawToImage not yet implemented: 'Not Reached', file /tmp/mozilla/gfx/src/xlib/nsImageXlib.cpp, line 1093 ###!!! Break: at file /tmp/mozilla/gfx/src/xlib/nsImageXlib.cpp, line 1093 Creating a new nsIToolkit! Enabling Quirk StyleSheet ###!!! ASSERTION: nsImageXlib::DrawToImage not yet implemented: 'Not Reached', file /tmp/mozilla/gfx/src/xlib/nsImageXlib.cpp, line 1093 ###!!! Break: at file /tmp/mozilla/gfx/src/xlib/nsImageXlib.cpp, line 1093 ###!!! ASSERTION: win is null. this happens [often on xlib builds]. see bug #79213: 'win', file /tmp/mozilla/content/events/src/nsEventStateManager.cpp, line 483 ###!!! Break: at file /tmp/mozilla/content/events/src/nsEventStateManager.cpp, line 483 ###!!! ASSERTION: win is null. this happens [often on xlib builds]. see bug #79213: 'win', file /tmp/mozilla/content/events/src/nsEventStateManager.cpp, line 483 ###!!! Break: at file /tmp/mozilla/content/events/src/nsEventStateManager.cpp, line 483 blank ###!!! ASSERTION: nsImageXlib::DrawToImage not yet implemented: 'Not Reached', file /tmp/mozilla/gfx/src/xlib/nsImageXlib.cpp, line 1093 ###!!! Break: at file /tmp/mozilla/gfx/src/xlib/nsImageXlib.cpp, line 1093 Document http://www.mozilla.org/ loaded successfully Program received signal SIGSEGV, Segmentation fault. 0xfe3a6bd8 in ?? () from /tmp/obj-sparc-sun-solaris2.7/dist/bin/components/libwidget_xlib.so (gdb) print mTransferable $1 = (nsITransferable *) 0x0 (gdb) bt #0 0xfe3a6bd8 in nsClipboard::GetData (this=0xfe3cda48, aTransferable=0x801b08, aWhichClipboard=1) at /tmp/mozilla/widget/src/xlib/nsClipboard.cpp:328 #1 0xfc68a28c in nsPlaintextEditor::Paste (this=0x8ba7f0, aSelectionType=1) at /tmp/mozilla/editor/base/nsPlaintextDataTransfer.cpp:527 #2 0xfc64e184 in nsPasteCommand::DoCommand (this=0x8b4fd8, aCommandName=@0xffbeea28, aCommandRefCon=0x8ba7f0) at /tmp/mozilla/editor/base/nsEditorCommands.cpp:228 #3 0xfdf1e9c0 in ?? () from /tmp/obj-sparc-sun-solaris2.7/dist/bin/components/libgkcontent.so #4 0xfc657b2c in nsEditorController::DoCommand (this=0x8ae868, aCommand=@0xffbeea28) at /tmp/mozilla/editor/base/nsEditorController.cpp:191 #5 0xfdfbf28c in ?? () from /tmp/obj-sparc-sun-solaris2.7/dist/bin/components/libgkcontent.so #6 0xfdfc9fb0 in ?? () from /tmp/obj-sparc-sun-solaris2.7/dist/bin/components/libgkcontent.so #7 0xfdda32a0 in ?? () from /tmp/obj-sparc-sun-solaris2.7/dist/bin/components/libgkcontent.so #8 0xfe04428c in ?? () from /tmp/obj-sparc-sun-solaris2.7/dist/bin/components/libgkcontent.so #9 0xfde0984c in ?? () from /tmp/obj-sparc-sun-solaris2.7/dist/bin/components/libgkcontent.so #10 0xfc964440 in ?? () from /tmp/obj-sparc-sun-solaris2.7/dist/bin/components/libgklayout.so #11 0xfc964010 in ?? () from /tmp/obj-sparc-sun-solaris2.7/dist/bin/components/libgklayout.so #12 0xfcf7fd3c in ?? () from /tmp/obj-sparc-sun-solaris2.7/dist/bin/components/libgkview.so #13 0xfcf8e378 in ?? () from /tmp/obj-sparc-sun-solaris2.7/dist/bin/components/libgkview.so #14 0xfcf7f1a4 in ?? () from /tmp/obj-sparc-sun-solaris2.7/dist/bin/components/libgkview.so #15 0xfe3af2f8 in nsWidget::DispatchEvent (this=0x56dba0, aEvent=0xffbef430, aStatus=@0xffbef33c) at /tmp/mozilla/widget/src/xlib/nsWidget.cpp:1276 #16 0xfe3af160 in nsWidget::DispatchWindowEvent (this=0x56dba0, aEvent=@0xffbef430) at /tmp/mozilla/widget/src/xlib/nsWidget.cpp:1184 #17 0xfe3af198 in nsWidget::DispatchKeyEvent (this=0x56dba0, aKeyEvent=@0xffbef430) at /tmp/mozilla/widget/src/xlib/nsWidget.cpp:1192 #18 0xfe3a39f0 in nsAppShell::HandleKeyPressEvent (event=0xffbef598, aWidget=0x56dba0) at /tmp/mozilla/widget/src/xlib/nsAppShell.cpp:1041 #19 0xfe3a2ce0 in nsAppShell::DispatchXEvent (event=0xffbef598) at /tmp/mozilla/widget/src/xlib/nsAppShell.cpp:625 #20 0xfe3a27fc in nsAppShell::Run (this=0xd9cc0) at /tmp/mozilla/widget/src/xlib/nsAppShell.cpp:454 #21 0xfd95c5c0 in ?? () from /tmp/obj-sparc-sun-solaris2.7/dist/bin/components/libnsappshell.so #22 0x1b630 in main1 (argc=3, argv=0xffbef92c, nativeApp=0x0) at /tmp/mozilla/xpfe/bootstrap/nsAppRunner.cpp:1010 #23 0x1c530 in main (argc=3, argv=0xffbef92c) at /tmp/mozilla/xpfe/bootstrap/nsAppRunner.cpp:1311 -- It looks like clipboard doesn't work ...

would someone review these patches? I'll check in either. I'm going to run w/ the second one for a while to see what happens.

r=dr on the first patch (34043). i don't know enough to comment on the second.

blizzard: please sr= the first patch. If you have time, could you comment on the second patch?

sr=blizzard on the first if it fixes a crash. It looks like you're papering over the problem, though.

band aid committed. i'll try to figure out correct fixes for this stuff later...