Closed
Bug 801915
Opened 12 years ago
Closed 12 years ago
IonMonkey: Handle JSOP_IN
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: sstangl, Unassigned)
References
Details
(Whiteboard: [ion:p2])
Attachments
(1 file)
(deleted),
patch
|
jandem
:
review+
bajaj
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Dromaeo's CSSQuery-Dojo test attempts to compile a function but fails for lack on Ion JSOP_IN support. Welp.
Sounds like this could matter for performance, if just to compile the surrounding function.
Whiteboard: [ion:p2]
Reporter | ||
Comment 2•12 years ago
|
||
Attachment #672147 -
Flags: review?
Reporter | ||
Updated•12 years ago
|
Attachment #672147 -
Flags: review? → review?(jdemooij)
Comment 3•12 years ago
|
||
Comment on attachment 672147 [details] [diff] [review]
Implement JSOP_IN using callVM.
Review of attachment 672147 [details] [diff] [review]:
-----------------------------------------------------------------
Nice. Both TM and JM+TI (bug 664824) have/had a fast path for "int32 in dense array". Can you file a follow-up bug so that we don't forget about it?
Attachment #672147 -
Flags: review?(jdemooij) → review+
Reporter | ||
Comment 4•12 years ago
|
||
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Comment on attachment 672147 [details] [diff] [review]
Implement JSOP_IN using callVM.
[Approval Request Comment]
Bug caused by (feature/regressing bug #): 786160
User impact if declined: Significant performance regression on benchmarks
Testing completed (on m-c, etc.): Yes
Risk to taking this patch (and alternatives if risky): Very little, might expose existing JIT bugs by nature of allowing more to JIT.
String or UUID changes made by this patch:
Attachment #672147 -
Flags: approval-mozilla-aurora?
Comment 7•12 years ago
|
||
Comment on attachment 672147 [details] [diff] [review]
Implement JSOP_IN using callVM.
Approving it on aurora as it has a significant perf impact
Attachment #672147 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 8•12 years ago
|
||
status-firefox18:
--- → fixed
status-firefox19:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•