Closed
Bug 801991
Opened 12 years ago
Closed 12 years ago
Remove the ability to generate custom quickstubs
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: emk, Assigned: Ms2ger)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
The last consumer has been removed by bug 734668. New interfaces should use WebIDL bindings.
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → Ms2ger
|
|
Assignee | |
Comment 1•12 years ago
|
||
Nothing much here, it seems.
Attachment #672491 -
Flags: review?(peterv)
|
Reporter | |
Comment 2•12 years ago
|
||
Comment on attachment 672491 [details] [diff] [review]
Patch v1
You are removing not customQuickStubs but customMethodCalls which is still used.
|
|
Assignee | |
Comment 3•12 years ago
|
||
Sorry?
|
|
Reporter | |
Comment 4•12 years ago
|
||
I think customQuickStubs should be removed from qsgen.py, but your patch removes customMethodCalls instead.
customMethodCalls is still used in dom_quickstubs.qsconf:
> customMethodCalls = {
> 'nsIDOMNode_GetNextSibling': {
> 'thisType': 'nsINode',
> 'code': ' nsINode *result = self->GetNextSibling();',
> 'canFail': False
> },
> 'nsIDOMNode_GetFirstChild': {
> 'thisType': 'nsINode',
|
|
Assignee | |
Comment 5•12 years ago
|
||
Good point, I did forget to remove the customQuickStubs variable. However, note that the references to customMethodCalls that I removed were only used to test for the 'skipGen' property, which was used to prevent the generation of the default quickstub when a custom one was present.
Attachment #672491 -
Attachment is obsolete: true
Attachment #672491 -
Flags: review?(peterv)
Attachment #672710 -
Flags: review?(peterv)
|
||
Updated•12 years ago
|
Attachment #672710 -
Flags: review?(peterv) → review+
|
|
Assignee | |
Comment 6•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•