Masatoshi Kimura [:emk] Reporter
	Description • 12 years ago

The last consumer has been removed by bug 734668. New interfaces should use WebIDL bindings.

	:Ms2ger (he/him; ⌚ UTC+1/+2) Assignee
	Comment 1 • 12 years ago

Nothing much here, it seems.

	Masatoshi Kimura [:emk] Reporter
	Comment 2 • 12 years ago

Comment on attachment 672491 [details] [diff] [review]
Patch v1

You are removing not customQuickStubs but customMethodCalls which is still used.

	:Ms2ger (he/him; ⌚ UTC+1/+2) Assignee
	Comment 3 • 12 years ago

Sorry?

	Masatoshi Kimura [:emk] Reporter
	Comment 4 • 12 years ago

I think customQuickStubs should be removed from qsgen.py, but your patch removes customMethodCalls instead.

customMethodCalls is still used in dom_quickstubs.qsconf:
> customMethodCalls = {
>     'nsIDOMNode_GetNextSibling': {
>         'thisType': 'nsINode',
>         'code': '    nsINode *result = self->GetNextSibling();',
>         'canFail': False
>         },
>     'nsIDOMNode_GetFirstChild': {
>         'thisType': 'nsINode',

	:Ms2ger (he/him; ⌚ UTC+1/+2) Assignee
	Comment 5 • 12 years ago

Good point, I did forget to remove the customQuickStubs variable. However, note that the references to customMethodCalls that I removed were only used to test for the 'skipGen' property, which was used to prevent the generation of the default quickstub when a custom one was present.

	:Ms2ger (he/him; ⌚ UTC+1/+2) Assignee
	Comment 6 • 12 years ago

https://hg.mozilla.org/mozilla-central/rev/647f0ed44f2f