Closed
Bug 802192
Opened 12 years ago
Closed 12 years ago
Make the AudioNode hierarchy not inherit from nsISupports
Categories
(Core :: Web Audio, defect)
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: ehsan.akhgari, Unassigned)
References
(Depends on 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
I have a patch to make AudioNode and its derived classes not inherit from nsISupports, and it seems to work. I need this now because I don't want other node types carry around the nsISupports baggage.
Reporter | ||
Comment 1•12 years ago
|
||
I got this to a point that it builds and doesn't crash when running tests, which is good. Then I faced assertions like this: "ASSERTION: nsCycleCollectionParticipant shouldn't change!". mccr8 tells me that I need to add a virtual GetParticipant function which returns the right type of participant based on the concrete type of the object, and that is on top of the virtual AddRef and Release methods that I had to add, so this is no longer worth doing in my opinion. I'm attaching the patch that I have here for future reference and WONTFIXing this.
Reporter | ||
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → WONTFIX
Comment 2•12 years ago
|
||
(In reply to Ehsan Akhgari [:ehsan] from comment #1)
> mccr8 tells me that I need
> to add a virtual GetParticipant function which returns the right type of
> participant based on the concrete type of the object, and that is on top of
> the virtual AddRef and Release methods that I had to add, so this is no
> longer worth doing in my opinion. I'm attaching the patch that I have here
> for future reference and WONTFIXing this.
Yeah, that's unfortunate. I suppose you expect AudioBufferSourceNode will have additional members it needs to traverse? Because in the patch it doesn't and so it shouldn't need its own CC participant or GetParticipant.
Comment 3•12 years ago
|
||
AudioBufferSourceNode has an additional field mBuffer needs to be traversed.
Reporter | ||
Comment 4•11 years ago
|
||
Mass moving Web Audio bugs to the Web Audio component. Filter on duckityduck.
Component: Video/Audio → Web Audio
You need to log in
before you can comment on or make changes to this bug.
Description
•