Closed
Bug 802399
Opened 12 years ago
Closed 12 years ago
Cannot select across the listed microphones when requesting gUM audio - all of them become active input sources, rather than the one mic selected
Categories
(Core :: WebRTC: Audio/Video, defect)
Tracking
()
VERIFIED
FIXED
mozilla19
Tracking | Status | |
---|---|---|
firefox17 | --- | unaffected |
firefox18 | --- | unaffected |
firefox19 | --- | verified |
firefox-esr17 | --- | unaffected |
People
(Reporter: jsmith, Assigned: jesup)
References
Details
(Whiteboard: [getUserMedia] [blocking-gum+])
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
derf
:
review+
|
Details | Diff | Splinter Review |
Steps:
1. Request audio from gUM with an integrated mic and a USB mic
2. When the permission prompt appears, select the USB mic
3. Put the MediaStream given into an audio tag and start playing it
4. Generate sounds into the integrated mic and USB mic
Expected:
The device's speakers should only be sending sound out from the USB mic.
Actual:
The device's speakers send sound out from both the integrated and USB mics.
Comment 1•12 years ago
|
||
Sounds like bug 797796 isn't working as expected, unless the front-end is sending bogus data to the back-end.
Reporter | ||
Comment 2•12 years ago
|
||
(In reply to Dão Gottwald [:dao] from comment #1)
> Sounds like bug 797796 isn't working as expected, unless the front-end is
> sending bogus data to the back-end.
Okay. I was debating on this one specifically if it's front-end or core.
Anant - Can you confirm this is a core issue?
Reporter | ||
Updated•12 years ago
|
Whiteboard: [getUserMedia] → [getUserMedia] [blocking-gum+]
Comment 3•12 years ago
|
||
Looks like a core issue, we'll take a look.
Reporter | ||
Updated•12 years ago
|
Component: General → WebRTC: Audio/Video
Product: Firefox → Core
QA Contact: jsmith
Assignee | ||
Comment 5•12 years ago
|
||
Further testing shows we were selecting the last device in the list always. This used to always be the first device on linux and mac, which is the 'default' device, due to another bug.
Assignee | ||
Comment 6•12 years ago
|
||
Comment on attachment 681845 [details] [diff] [review]
set capture index for audio input when device is Allocate()ed
I left the SetRecordingDevice() in Init() to verify it can record; may not really be needed.
Attachment #681845 -
Flags: review?(anant)
Comment 7•12 years ago
|
||
Hmm, this might be tricky. Since we're using the same engine, if I call Allocate() on another object, then the device index gets changed. Would it be better if we move to SetRecordingDevice call to Start()?
Assignee | ||
Comment 8•12 years ago
|
||
Even worse: capture microphone 1 in tab 1. Capture microphone 2 in tab 2. What microphone data does each see?
(was just trying this to test another bug; it doesn't work of course)
Comment 9•12 years ago
|
||
Comment on attachment 681845 [details] [diff] [review]
set capture index for audio input when device is Allocate()ed
Review of attachment 681845 [details] [diff] [review]:
-----------------------------------------------------------------
Stealing review at jesup's request.
::: content/media/webrtc/MediaEngineWebRTCAudio.cpp
@@ +52,5 @@
> if (mState != kReleased) {
> return NS_ERROR_FAILURE;
> }
>
> + webrtc::VoEHardware* ptrVoEHw = webrtc::VoEHardware::GetInterface(mVoiceEngine);
If you call GetInterface(), you need to call Release().
Attachment #681845 -
Flags: review?(anant) → review-
Assignee | ||
Comment 10•12 years ago
|
||
Also plugs an existing leak of ptrVoEHw in ::Init()
Assignee | ||
Updated•12 years ago
|
Attachment #681845 -
Attachment is obsolete: true
Assignee | ||
Updated•12 years ago
|
Attachment #682226 -
Flags: review?(tterribe)
Updated•12 years ago
|
Attachment #682226 -
Flags: review?(tterribe) → review+
Assignee | ||
Comment 11•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/5444aff38dfb
FF17/18 are unaffected by this bug because it was introduced shortly after last uplift (other than the leak)
status-firefox17:
--- → unaffected
status-firefox18:
--- → unaffected
status-firefox19:
--- → affected
status-firefox-esr17:
--- → unaffected
Target Milestone: --- → mozilla19
Comment 12•12 years ago
|
||
Assignee: nobody → rjesup
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Reporter | ||
Updated•12 years ago
|
Updated•12 years ago
|
Reporter | ||
Comment 13•12 years ago
|
||
Verified on 11/19.
Reporter | ||
Comment 14•12 years ago
|
||
If we could fake the devices, we might be able to automate this. Although as it stands in the current framework, we don't have this ability. Putting in-testsuite- for now, although if device faking becomes possible at some point, then we should re-evaluate this one for a test.
Flags: in-testsuite-
You need to log in
before you can comment on or make changes to this bug.
Description
•