Closed
Bug 802506
Opened 12 years ago
Closed 12 years ago
[MMI] Marionette tests for getIMEI via MMI
Categories
(Core :: DOM: Device Interfaces, defect)
Core
DOM: Device Interfaces
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: ferjm, Assigned: vicamo)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
vicamo
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → vyang
|
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #705913 -
Flags: review?(ferjmoreno)
|
Reporter | |
Comment 2•12 years ago
|
||
Comment on attachment 705913 [details] [diff] [review]
add marionette test case for getting IMEI
Review of attachment 705913 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks Vicamo!
::: dom/network/tests/marionette/manifest.ini
@@ +11,5 @@
> [test_mobile_preferred_network_type.js]
> disabled = Bug 808783
> [test_mobile_data_location.js]
> [test_mobile_data_state.js]
> +[test_mobile_ussd.js]
Since you are testing the retrieval of the IMEI code, this should probably be named 'test_mobile_mmi.js' instead.
::: dom/network/tests/marionette/test_mobile_ussd.js
@@ +7,5 @@
> +
> +let mobileConnection = navigator.mozMobileConnection;
> +
> +let tasks = {
> + // List of test fuctions. Each of them should call |tasks.next()| when
typo: 'functions'.
Attachment #705913 -
Flags: review?(ferjmoreno) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Address review comment in comment #2.
Attachment #705913 -
Attachment is obsolete: true
Attachment #706850 -
Flags: review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
|
||
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in
before you can comment on or make changes to this bug.
Description
•