Closed
Bug 803520
Opened 12 years ago
Closed 12 years ago
Don't use JSCList for JSRuntime::contextList
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #673214 -
Flags: review?(jwalden+bmo)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 673214 [details] [diff] [review]
Patch v1
Review of attachment 673214 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/jsapi.cpp
@@ +972,5 @@
> #endif
>
> #ifdef DEBUG
> /* Don't hurt everyone in leaky ol' Mozilla with a fatal JS_ASSERT! */
> + if (!contextList.isEmpty()) {
This probably reads better as hasContexts().
::: js/src/jscntxt.h
@@ +1215,5 @@
>
> } /* namespace js */
>
> struct JSContext : js::ContextFriendFields
> + , public mozilla::LinkedListElement<JSContext>
struct JSContext
: js::ContextFriendFields,
public mozilla::LinkedListElement<JSContext>
Attachment #673214 -
Flags: review?(jwalden+bmo) → review+
|
Assignee | |
Comment 2•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in
before you can comment on or make changes to this bug.
Description
•