Closed Bug 803666 Opened 12 years ago Closed 12 years ago

convert nsDocLoader's outstanding status list to use mozilla::LinkedList

Categories

(Core :: DOM: Navigation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla19

People

(Reporter: froydnj, Assigned: froydnj)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Blocks: 803441
Comment on attachment 673385 [details] [diff] [review] convert nsDocLoader's outstanding status list to use mozilla::LinkedList > protected: >+ struct nsStatusInfo : public mozilla::LinkedListElement<nsStatusInfo> { { should be in the next line. >+ ~nsStatusInfo() >+ { >+ MOZ_COUNT_DTOR(nsStatusInfo); >+ this->remove(); I assume it is guaranteed 'this' is in the list here. (As far as I see, that is the case) >+ } >+ }; >+ >+ struct nsRequestInfo : public PLDHashEntryHdr >+ { >+ nsRequestInfo(const void *key) Should be const void* aKey, but you're just moving this code so no need to change in this case (or feel free to change, but change then also the hashtable callback functions).
Attachment #673385 - Flags: review?(bugs) → review+
Assignee: nobody → nfroyd
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Unfortunately the inbound push this landed in broke Linux PGO, so push backed out (see bug 809756). https://hg.mozilla.org/mozilla-central/rev/82c59210f11f
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla19 → ---
Status: REOPENED → RESOLVED
Closed: 12 years ago12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: