Closed
Bug 803666
Opened 12 years ago
Closed 12 years ago
convert nsDocLoader's outstanding status list to use mozilla::LinkedList
Categories
(Core :: DOM: Navigation, defect)
Core
DOM: Navigation
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: froydnj, Assigned: froydnj)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #673385 -
Flags: review?(bugs)
Comment 2•12 years ago
|
||
Comment on attachment 673385 [details] [diff] [review]
convert nsDocLoader's outstanding status list to use mozilla::LinkedList
> protected:
>+ struct nsStatusInfo : public mozilla::LinkedListElement<nsStatusInfo> {
{ should be in the next line.
>+ ~nsStatusInfo()
>+ {
>+ MOZ_COUNT_DTOR(nsStatusInfo);
>+ this->remove();
I assume it is guaranteed 'this' is in the list here.
(As far as I see, that is the case)
>+ }
>+ };
>+
>+ struct nsRequestInfo : public PLDHashEntryHdr
>+ {
>+ nsRequestInfo(const void *key)
Should be const void* aKey, but you're just moving this code so no need to change in
this case (or feel free to change, but change then also the hashtable callback functions).
Attachment #673385 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 3•12 years ago
|
||
Assignee | ||
Comment 4•12 years ago
|
||
Assignee: nobody → nfroyd
Status: NEW → ASSIGNED
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Comment 6•12 years ago
|
||
Unfortunately the inbound push this landed in broke Linux PGO, so push backed out (see bug 809756).
https://hg.mozilla.org/mozilla-central/rev/82c59210f11f
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla19 → ---
Comment 7•12 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in
before you can comment on or make changes to this bug.
Description
•