Gregor Wagner [:gwagner] Assignee
	Description • 12 years ago

We need this to allow readonly access to the settings api for example.

	Gregor Wagner [:gwagner] Assignee
	Comment 2 • 12 years ago

now without debug output

	Jonas Sicking (:sicking) No longer reading bugmail consistently
	Comment 4 • 12 years ago

Comment on attachment 675344 [details] [diff] [review]
Gaia patch

Review of attachment 675344 [details] [diff] [review]:
-----------------------------------------------------------------

::: apps/camera/manifest.webapp
@@ +10,5 @@
>      "url": "https://github.com/mozilla-b2g/gaia"
>    },
>    "permissions": {
> +    "device-storage:pictures":{ "access": "readcreate" },
> +    "device-storage:videos":{ "access": "readcreate" },

I think these can be "createonly", but I'm not sure.

::: apps/communications/manifest.webapp
@@ +28,4 @@
>    "permissions": {
>      "telephony":{},
>      "voicemail":{},
> +    "contacts":{ "access": "readcreate" },

This should be "readwrite"

::: apps/gallery/manifest.webapp
@@ +8,4 @@
>      "url": "https://github.com/mozilla-b2g/gaia"
>    },
>    "permissions": {
> +    "device-storage:pictures":{ "access": "readonly" },

This needs "readwrite" in order to delete pictures.

::: apps/homescreen/manifest.webapp
@@ +9,5 @@
>    "permissions": {
>      "webapps-manage":{},
>      "systemXHR":{},
> +    "settings":{ "access": "readonly" },
> +    "device-storage:pictures":{ "access": "readcreate" }

Shouldn't "readonly" be enough here?

::: apps/music/manifest.webapp
@@ +8,4 @@
>      "url": "https://github.com/mozilla-b2g/gaia"
>    },
>    "permissions": {
> +    "device-storage:music":{ "access": "readcreate" },

probably needs "readwrite" in order to delete songs.

::: apps/system/manifest.webapp
@@ +18,3 @@
>      "telephony":{},
>      "voicemail":{},
>      "device-storage:pictures":{},

Probably needs "readcreate" here to save screenshots

::: apps/video/manifest.webapp
@@ +8,4 @@
>      "url": "https://github.com/mozilla-b2g/gaia"
>    },
>    "permissions": {
> +    "device-storage:videos":{ "access": "readonly" },

This probably needs "readwrite" in order to delete videos

::: test_apps/image-uploader/manifest.webapp
@@ +7,4 @@
>    },
>    "permissions": {
>      "systemXHR":{},
> +    "device-storage:pictures":{ "access": "readcreate" }

I suspect "readonly" is enough here.

::: test_apps/uitest/manifest.webapp
@@ +11,4 @@
>    "permissions": {
>      "backgroundservice":{},
>      "attention":{},
> +    "contacts":{ "access": "readcreate" },

readwrite maybe?

	David Dahl :ddahl
	Comment 5 • 12 years ago

Comment on attachment 675335 [details] [diff] [review]
patch

Looks Good

	Gregor Wagner [:gwagner] Assignee
	Comment 6 • 12 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/55e06361e08e

	Ryan VanderMeulen [:RyanVM]
	Comment 7 • 12 years ago

https://hg.mozilla.org/mozilla-central/rev/55e06361e08e

	Jason Smith [:jsmith]
	Comment 8 • 12 years ago

Umm...where's the reference to the Gaia portion of the patch?

	Gregor Wagner [:gwagner] Assignee
	Comment 9 • 12 years ago

(In reply to Jason Smith [:jsmith] from comment #8)
> Umm...where's the reference to the Gaia portion of the patch?

Hasn't landed yet because we have distribute the gecko part on all trees first.
Otherwise we would break nightly again.

	Ryan VanderMeulen [:RyanVM]
	Comment 10 • 12 years ago

https://hg.mozilla.org/releases/mozilla-aurora/rev/4aa98258250b

	Gregor Wagner [:gwagner] Assignee
	Comment 11 • 12 years ago

Gaia part:
https://github.com/mozilla-b2g/gaia/pull/6063