Tim Taubert [:ttaubert] (inactive) Assignee
	Description • 12 years ago

The signature for .startRecording() has changed. We need to wait until bug 805377 is fixed or we won't even get here. I have a patch almost ready and will post it tomorrow.

	Tim Taubert [:ttaubert] (inactive) Assignee
	Comment 1 • 12 years ago

This should block because we can't record video at all at the moment.

	Tim Taubert [:ttaubert] (inactive) Assignee
	Comment 2 • 12 years ago

Even with the signature fixed, recording fails. I tracked it down so far that GonkCameraSource::initCheck() return false and so we fail here:

http://mxr.mozilla.org/mozilla-central/source/dom/camera/GonkRecorder.cpp#1139

	Tim Taubert [:ttaubert] (inactive) Assignee
	Comment 3 • 12 years ago

(In reply to Tim Taubert [:ttaubert] from comment #2)
> Even with the signature fixed, recording fails. I tracked it down so far
> that GonkCameraSource::initCheck() returns false.

Filed bug 805777, the frame rate is unsupported.

	Tim Taubert [:ttaubert] (inactive) Assignee
	Comment 4 • 12 years ago

Pointer to Github pull-request

	Tim Taubert [:ttaubert] (inactive) Assignee
	Comment 5 • 12 years ago

Comment on attachment 675524 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6025

There's a couple of changes here:

1) The overlay does now disappear if you click it. I don't know if it's supposed to fade away automatically but I didn't find any code for that so I just assumed we need that.

2) As soon as I got this._cameraObj.startRecording() working again it always failed - because of bug 805777. I figured it would be better to have an error message than nothing happening.

3) startRecording() does now support a maxFileSizeBytes parameter which I think we should use to constraint used disk space by videos. I replaced the old code that periodically checks with a one-time check before the recording starts.

	Tim Taubert [:ttaubert] (inactive) Assignee
	Comment 6 • 12 years ago

This problem is actually not unagi-specific.

	Dale Harvey (:daleharvey)
	Comment 7 • 12 years ago

https://github.com/mozilla-b2g/gaia/commit/5817b97ab660de8808d6ee98f97d89d6f1be639d

	Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)
	Comment 8 • 12 years ago

Still happen.

	Mike Habicher [:mikeh] (high bugzilla latency)
	Comment 9 • 12 years ago

(In reply to Vivien Nicolas (:vingtetun) from comment #8)
> Still happen.

Vivien, can you confirm that you have on your DUT:
- /system/lib/libOmxVidEnc.so, and
- /system/etc/media_profiles.xml of 18,066 bytes.

If you don't, recorder won't work.  This has been fixed in recent builds.

If you do, STR?

	Tim Taubert [:ttaubert] (inactive) Assignee
	Comment 10 • 12 years ago

Video recording should at the moment work on Otoro, only. There still is bug 800627, right?

	Julien Wajsberg [:julienw]
	Comment 11 • 12 years ago

video recording works for me on unagi.

However we have no UI feedback that it is correctly saved, but it should belong in another bug.

	Dale Harvey (:daleharvey)
	Comment 12 • 12 years ago

Video recording works on the unagi

It requires files that we cannot distribute so if you have a phone that was flashed prior to these files being added to the build you will need to flash a new nightly.

The confirmation is already an open bug

	amiller
	Comment 13 • 12 years ago

Device: Unagi
Build: 20130102070202

Recording works on the new build at this time.