Closed Bug 806127 Opened 12 years ago Closed 12 years ago

ThirdPartyUtil should consider browser/app frames to be top-level windows.

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla19
Project Flags:
blocking-basecamp +
Tracking Flags:
Tracking Status
firefox18 --- fixed
firefox19 --- fixed

People

(Reporter: justin.lebar+bug, Assigned: justin.lebar+bug)

References

Details

Attachments

(2 files)

Patch, v1
(deleted), patch
bzbarsky
: review+
Details | Diff | Splinter Review
Tests for cookies.
(deleted), patch
bzbarsky
: review+
Details | Diff | Splinter Review
An in-process <iframe mozbrowser/mozapp> can't access IndexedDB because it's considered third-party by ThirdPartyUtil. Simple patch in a moment, but we should have a test for this. I'm really surprised we're not hitting this in B2G.
Blocks: 802366
Assignee: nobody → justin.lebar+bug
I think this is a blocker since I believe we're planning on writing various apps which wraps websites using <iframe mozbrowser>. Such apps would break IDB currently.
blocking-basecamp: --- → +
(In reply to Jonas Sicking (:sicking) from comment #1) > I think this is a blocker since I believe we're planning on writing various > apps which wraps websites using <iframe mozbrowser>. Such apps would break > IDB currently. Unless the framed content is same-origin to the wrapping app, yes.
Attached patch Patch, v1 (deleted) — — Splinter Review
I have a test which I'll post in bug 802366 which checks the IsThirdPartyWindow change. But I need to look into how to test the IsThirdPartyChannel change.
Attachment #675918 - Flags: review?(bzbarsky)
Okay, we can write a test for IsThirdPartyChannel by setting network.cookie.cookieBehavior to 1 and trying to write a cookie.
Blocks: 806168
No longer blocks: 802366
> I have a test which I'll post in bug 802366 which checks the IsThirdPartyWindow change. This ended up going in bug 806168. I'll do the cookie service change here, though.
Attached patch Tests for cookies. (deleted) — — Splinter Review
Attachment #675971 - Flags: review?(bzbarsky)
Blocks: 805145
No longer blocks: 805145
Comment on attachment 675918 [details] [diff] [review] Patch, v1 r=me
Attachment #675918 - Flags: review?(bzbarsky) → review+
Comment on attachment 675971 [details] [diff] [review] Tests for cookies. r=me
Attachment #675971 - Flags: review?(bzbarsky) → review+
Landed on inbound; see bug 802366 comment 46.
And backed out for further orange; see bug 802366 comment 48.
Sorry, but this got caught up in the bug 802366 bustage and was backed out. https://hg.mozilla.org/integration/mozilla-inbound/rev/5dc1c0530b00
https://hg.mozilla.org/mozilla-central/rev/18abb3f6d91a https://hg.mozilla.org/mozilla-central/rev/9b762aa96799
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: