Closed
Bug 806329
Opened 12 years ago
Closed 12 years ago
Restore MPL 2 headers removed by recent pdf.js update
Categories
(Firefox :: PDF Viewer, defect, P1)
Firefox
PDF Viewer
Tracking
()
RESOLVED
FIXED
Firefox 19
People
(Reporter: gerv, Assigned: bdahl)
References
Details
(Whiteboard: [pdfjs-c-integration])
A recent pdf.js update:
https://hg.mozilla.org/mozilla-central/rev/af98d67916ad
removed the MPL 2 headers added in:
https://hg.mozilla.org/mozilla-central/rev/74a06c56da4e
Could this please be fixed?
It might also be worth investigating why the update procedure for pdf.js does not seem to involve merging with the current code, but rather overwriting it...
Gerv
Comment 1•12 years ago
|
||
Gerv,
PDF Viewer component portion is licensed under Apache license v2 and .properties files are part of it. Shall those files be MPL2?
> It might also be worth investigating why the update procedure for pdf.js does not seem to involve merging with the current code, but rather overwriting it...
We are tracking this issue at https://github.com/mozilla/pdf.js/issues/2275
Reporter | ||
Comment 2•12 years ago
|
||
Yury: good point :-) If these files are part of pdf.js itself (and not part of Mozilla's integration of pdf.js) then yes, they need Apache headers instead.
Gerv
Assignee | ||
Comment 3•12 years ago
|
||
These files are used in our web based viewer as well, so I think the apache header makes more sense. We'll fix upstream.
Priority: -- → P1
Whiteboard: [pdfjs-c-integration]
Comment 4•12 years ago
|
||
Fixed by bug 810107.
Assignee: nobody → bdahl
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
You need to log in
before you can comment on or make changes to this bug.
Description
•