Closed
Bug 806592
Opened 12 years ago
Closed 12 years ago
[meta] Improve SMS app performance
Categories
(Firefox OS Graveyard :: Gaia::SMS, defect)
Tracking
(Not tracked)
RESOLVED
WORKSFORME
People
(Reporter: cjones, Unassigned)
References
Details
(Keywords: perf, Whiteboard: UX-P2)
It takes about 10 seconds for the SMS app to load on my unagi after I've been dogfooding for about a week.
I'm not a very heavy SMS-er, so I'm guessing I have at most 100 stored messages by now.
Comment 1•12 years ago
|
||
We have to send out some general guidance on this. I am seeing tons of heavy startup code in apps. The rule should be to exactly do nothing during startup.
Comment 2•12 years ago
|
||
Blocking+: This needs to be fixed sooner rather than later.
blocking-basecamp: ? → +
Priority: -- → P2
Updated•12 years ago
|
Assignee: nobody → fabrice
Reporter | ||
Comment 3•12 years ago
|
||
Note, the SMS app currently loads an omgbigfatslow JS library, which I think dings startup by 3 or 4 seconds. We have a separate fix for that in hand. The work here is on killing the extra 6-7s.
Comment 4•12 years ago
|
||
After talking with [:philikon] and [:ferjm] we have realized that there are key points for increasing the performance. What do you think about opening a new bug for making SMS App faster in Gaia and this one for all improvements in Gecko?
Reporter | ||
Comment 5•12 years ago
|
||
Sure, if that makes things easier.
Comment 6•12 years ago
|
||
From Gaia we are gonna make this process in two steps:
- [PhoneNumberJS] https://bugzilla.mozilla.org/show_bug.cgi?id=808815
- [Intermediate Cache] https://bugzilla.mozilla.org/show_bug.cgi?id=808819
We could keep this bug for tracking the improvements on Gecko, what do you think [:ferjm]?
Comment 7•12 years ago
|
||
We can keep this bug for tracking both improvements, Gecko and Gaia sides.
Updated•12 years ago
|
Assignee: fabrice → nobody
Updated•12 years ago
|
Updated•12 years ago
|
Component: Gaia → Gaia::SMS
Updated•12 years ago
|
Updated•12 years ago
|
Updated•12 years ago
|
Whiteboard: UX-P1 → UX-P2
Reporter | ||
Comment 11•12 years ago
|
||
http://i.qkme.me/3stf5m.jpg
I really hope we're not considering trying to ship a phone that takes 10 seconds and up (unbounded) to render a core part of the *phone* experience.
We need to improve this with worke that's feasible and upliftable in the v1 timeframe. Is that work one of the dep bugs here?
Comment 12•12 years ago
|
||
Hi Chris. We are going to work on the conversation view in the following bug https://bugzilla.mozilla.org/show_bug.cgi?id=827815 ! During this week we are gonna discuss some solutions with UX team, bug at the end it's gonna be related with some 'pagination' as 'What'sup' . If you have any proposal don't hesitate to add a comment to the optimization bug! Thanks!
Reporter | ||
Comment 13•12 years ago
|
||
Note that I said "upliftable in the v1 timeframe". That bug is a major change with new UX.
Why can't we keep the current design but just insert messages into the UI in chunks instead of all at once? That is, load 10, then load another X, ...
Comment 14•12 years ago
|
||
Hi Chris! Good news about SMS! Im testing a patch that it's capable of loading a huge list of SMS in a thread (~2500 messages) and the infinite scrolling it's working as a expected! I've upload a video and I will make the PR asap (I have to modify the 'Header' creation method). Stay tuned!
Here the Video:
http://youtu.be/54OsQWyYHF4
http://cdn.memegenerator.net/instances/400x/34549453.jpg ;)
Reporter | ||
Comment 15•12 years ago
|
||
That's more like it! :)
Comment 16•12 years ago
|
||
(In reply to Chris Jones [:cjones] [:warhammer] from comment #15)
> That's more like it! :)
Chris, here we have the patch for SMS!
https://github.com/mozilla-b2g/gaia/pull/8041
Could you try with your SMS DB and and this patch in order to check the performance? Everything is tracked in the following bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=827815
Thanks a lot!
Flags: needinfo?(jones.chris.g)
Reporter | ||
Comment 17•12 years ago
|
||
My sms db is gone :( (bug 839422).
But this is what bug 837281 is for :).
Flags: needinfo?(jones.chris.g)
Comment 18•12 years ago
|
||
Chris, the patch is merged in Master! ;)
Reporter | ||
Comment 19•12 years ago
|
||
SMS feels like a commercial product now, will go ahead and close this bug although the remaining work is still worth doing.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•