Closed
Bug 806611
Opened 12 years ago
Closed 12 years ago
Wifi: Add runtime support for turning on wifi debugging output
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(firefox18 fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox18 | --- | fixed |
People
(Reporter: mrbkap, Assigned: mrbkap)
References
Details
Attachments
(2 files, 1 obsolete file)
(deleted),
patch
|
vchang
:
review+
bajaj
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
vchang
:
review+
vchang
:
review+
bajaj
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Right now, getting wifi debug output is purely compile time: one has to set a variable in the source code to "true". We should add an option that can be set at run-time as well.
Assignee | ||
Comment 1•12 years ago
|
||
This works, but is going to be obsoleted by bug 798491. I'll attach a new patch later today that fixes that.
Assignee | ||
Comment 2•12 years ago
|
||
This seems to work. I have a second patch coming that I'll attach here that also turns on wpa_supplicant's debugging at the same time, which should provide more useful logcat messages.
Attachment #676387 -
Attachment is obsolete: true
Attachment #676818 -
Flags: review?(vchang)
Assignee | ||
Comment 3•12 years ago
|
||
This makes wpa_supplicant much more noisy when debug is enabled for wifi. Vincent, do you think this is worth the extra noise when wifi debugging is enabled?
Attachment #676864 -
Flags: review?(vchang)
Comment 4•12 years ago
|
||
I think this patch is useful for WiFi debugging.
But we can use "wpa_cli" command instead of this.
We can change debug log level to most verbose by typing below.
$ adb shell wpa_cli log_level debug
I think "wpa_cli" is better. Because anybody can use this command who can use "adb logcat".
Comment 5•12 years ago
|
||
Comment on attachment 676864 [details] [diff] [review]
Make wpa_supplicant noisy too
Review of attachment 676864 [details] [diff] [review]:
-----------------------------------------------------------------
wpa_cli doesn't install to /system/bin/ in recently build.
We need debug messages of wpa_supplicant in certain bugs.
Now I can use js console to turn on/off debug dynamically.
It's really cool and useful.
adb forward tcp:9999 tcp:9999
netcat localhost 9999
navigator.mozSettings.createLock().set({'wifi.debugging.enabled': true})
navigator.mozSettings.createLock().set({'wifi.debugging.enabled': false})
Attachment #676864 -
Flags: review?(vchang)
Attachment #676864 -
Flags: review+
Updated•12 years ago
|
Attachment #676818 -
Flags: review?(vchang) → review+
Assignee | ||
Comment 6•12 years ago
|
||
Assignee | ||
Comment 7•12 years ago
|
||
Comment on attachment 676818 [details] [diff] [review]
patch v1
[Approval Request Comment]
Bug caused by (feature/regressing bug #):
User impact if declined: It will be more difficult to debug wifi issues.
Testing completed (on m-c, etc.): Locally.
Risk to taking this patch (and alternatives if risky):
String or UUID changes made by this patch:
Attachment #676818 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 8•12 years ago
|
||
Comment on attachment 676864 [details] [diff] [review]
Make wpa_supplicant noisy too
[Approval Request Comment]
Bug caused by (feature/regressing bug #):
User impact if declined:
Testing completed (on m-c, etc.):
Risk to taking this patch (and alternatives if risky): Both this patch and the previous one should only cause problems for people who are attempting to debug wifi.
String or UUID changes made by this patch:
Attachment #676864 -
Flags: approval-mozilla-aurora?
Comment 9•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6706f42b153b
https://hg.mozilla.org/mozilla-central/rev/c999fc311c28
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Attachment #676818 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•12 years ago
|
Attachment #676864 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 10•12 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/deb39a21892f
https://hg.mozilla.org/releases/mozilla-aurora/rev/8e94d84fd6e3
status-firefox18:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•