Closed
Bug 806706
Opened 12 years ago
Closed 12 years ago
Port browser_save_link.js to the new per-window PB APIs
Categories
(Firefox :: Private Browsing, defect)
Tracking
()
RESOLVED
FIXED
Firefox 19
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
jdm
:
review+
|
Details | Diff | Splinter Review |
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/test/browser_save_link.js
In order to port this test, the file needs to be copied to the same directory (perhaps with "_perwindowpb" appended to its file name), and then instead of setting privateBrowsingEnabled, we need to open a new private browsing window and then run the test on that window. Note that the original test should only be added to the list of test files in Makefile.in ifndef MOZ_PER_WINDOW_PRIVATE_BROWSING, and the new test file should be added to the list with the reverse condition.
Assignee | ||
Comment 1•12 years ago
|
||
This patch should do the job, but the PB portion of the test fails with:
18.74 TEST-UNEXPECTED-FAIL| chrome://mochitests/content/browser/browser/base/content/test/browser_save_link-perwindowpb.js | no cookie should be sent - Got cookie-present, expected cookie-not-present
This test was added in bug 792517. Josh, could you please take a look to see why? The correct private bit seems to be set on the channel.
Comment 2•12 years ago
|
||
It's failing because bug 722850 hasn't landed yet, so it's using the public cookie database.
Assignee | ||
Comment 3•12 years ago
|
||
Oh, right!
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → ehsan
Assignee | ||
Updated•12 years ago
|
Attachment #679061 -
Flags: review?(josh)
Updated•12 years ago
|
Attachment #679061 -
Flags: review?(josh) → review+
Assignee | ||
Comment 4•12 years ago
|
||
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
You need to log in
before you can comment on or make changes to this bug.
Description
•