Closed Bug 806708 Opened 12 years ago Closed 12 years ago

Port browser_tabMatchesInAwesomebar.js to the new per-window PB APIs

Categories

(Firefox :: Private Browsing, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 20

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

http://mxr.mozilla.org/mozilla-central/source/browser/base/content/test/browser_tabMatchesInAwesomebar.js In order to port this test, the file needs to be copied to the same directory (perhaps with "_perwindowpb" appended to its file name), and then instead of setting privateBrowsingEnabled, we need to open a new private browsing window and then run the test on that window. Note that the original test should only be added to the list of test files in Makefile.in ifndef MOZ_PER_WINDOW_PRIVATE_BROWSING, and the new test file should be added to the list with the reverse condition.
Assignee: nobody → andres
Attached patch Patch (v1) (deleted) — Splinter Review
This basically removes the PB checks from that test, since we test all interesting combinations in browser_bug816527.js. Taking this in order to help make Birch green again...
Assignee: andres → ehsan
Status: NEW → ASSIGNED
Attachment #688736 - Flags: review?(josh)
Attachment #688736 - Flags: review?(josh) → review+
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: