Closed
Bug 806711
Opened 12 years ago
Closed 12 years ago
Port do_test_placesTitleNoUpdate.js to the new per-tab PB APIs
Categories
(Firefox :: Private Browsing, defect)
Tracking
()
RESOLVED
FIXED
Firefox 20
People
(Reporter: ehsan.akhgari, Assigned: raymondlee)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
jdm
:
review+
|
Details | Diff | Splinter Review |
http://mxr.mozilla.org/mozilla-central/source/browser/components/privatebrowsing/test/unit/do_test_placesTitleNoUpdate.js
In order to port this test, the file needs to be copied to the perwindow directory, and then it needs to be rewritten as a browser-chrome test. Instead of setting privateBrowsingEnabled, we need to open a new private browsing window and then run the test on that window.
Comment 1•12 years ago
|
||
This is being modified radically by bug 723005.
Reporter | ||
Comment 2•12 years ago
|
||
This is now ready to be worked on.
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → raymond
Assignee | ||
Comment 3•12 years ago
|
||
The original test doesn't seem to do anything, other than adding a entry to Places and do a check because some of the code were removed in patch for bug 723005.
http://mxr.mozilla.org/mozilla-central/source/browser/components/privatebrowsing/test/unit/do_test_placesTitleNoUpdate.js
Therefore, I have made the browser test to do what it should be.
1) Open a page with title "Test 1" in a normal window
2) Update entry in Places for the test url with title "Test 2" in a normal window
3) Open a page with title "Test 1" in a private window and check to ensure the entry's title in Places remains "Test 2".
Attachment #692214 -
Flags: review?(ehsan)
Assignee | ||
Updated•12 years ago
|
Status: NEW → ASSIGNED
Updated•12 years ago
|
Attachment #692214 -
Flags: review?(ehsan) → review+
Reporter | ||
Comment 4•12 years ago
|
||
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
You need to log in
before you can comment on or make changes to this bug.
Description
•