Closed
Bug 807171
Opened 12 years ago
Closed 12 years ago
Implement AudioParam.cancelScheduledValues
Categories
(Core :: Web Audio, defect)
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•12 years ago
|
||
|
||
Comment 2•12 years ago
|
||
Comment on attachment 676849 [details] [diff] [review]
Patch (v1)
>+ mEvents.RemoveElementsAt(i, mEvents.Length() - i);
mEvents.TruncateLength(i);
r=me
Attachment #676849 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
|
|
||
Comment 4•12 years ago
|
||
One other thought.... would it make sense to binary search instead of linear search here?
|
|
Assignee | |
Comment 5•12 years ago
|
||
(In reply to comment #4)
> One other thought.... would it make sense to binary search instead of linear
> search here?
Maybe. I don't yet know how many events will be typically set on an AudioParam, so depending on the real world use case that may not be worth it. I have a comment in AudioEventTimeline.h which says how mEvents can be optimized in the future if we need to.
|
||
Comment 6•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
|
|
Assignee | |
Comment 7•11 years ago
|
||
Mass moving Web Audio bugs to the Web Audio component. Filter on duckityduck.
Component: Video/Audio → Web Audio
You need to log in
before you can comment on or make changes to this bug.
Description
•