Closed
Bug 807315
Opened 12 years ago
Closed 12 years ago
[AccessFu] We spend 15ms running AccessFu.jsm on mobile startup
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(fennec+)
RESOLVED
FIXED
Firefox 19
Tracking | Status | |
---|---|---|
fennec | + | --- |
People
(Reporter: ehsan.akhgari, Assigned: eeejay)
References
Details
(Keywords: perf)
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
davidb
:
review+
|
Details | Diff | Splinter Review |
Comment 1•12 years ago
|
||
Over to Eitan.
Ehsan did you have accessibility settings turned on on android?
Assignee: dbolter → eitan
Updated•12 years ago
|
Keywords: perf
Summary: We spend 15ms running AccessFu.jsm on mobile startup → [AccessFu] We spend 15ms running AccessFu.jsm on mobile startup
Comment 2•12 years ago
|
||
I grabbed the profile. I didn't opt into anything. How do I check?
Updated•12 years ago
|
OS: Mac OS X → Android
Hardware: x86 → ARM
Comment 3•12 years ago
|
||
Update: accessibility setting was not enabled AFAICT
Updated•12 years ago
|
tracking-fennec: --- → ?
Assignee | ||
Comment 4•12 years ago
|
||
Is there such a thing as an acceptable amount of time?
Reporter | ||
Comment 5•12 years ago
|
||
(In reply to comment #4)
> Is there such a thing as an acceptable amount of time?
Yes, 0. ;-)
Assignee | ||
Comment 6•12 years ago
|
||
Fair enough :)
Assignee | ||
Comment 7•12 years ago
|
||
Here is the profile before:
http://people.mozilla.com/~bgirard/cleopatra/?report=298ba1521e337073883f9e7857e5ea7119e64b83
Here it is after:
http://people.mozilla.com/~bgirard/cleopatra/?report=0a4abc01084588a58c88a4848467df61e03e09ec
I'm still new to this tool. But it looks like startup in AccessFu dropped from 27ms to 2ms, not quite 0 :)
Need to test this patch further to make sure it does not break stuff.
Reporter | ||
Comment 8•12 years ago
|
||
Couldn't you just replace these with lazy getters?
Assignee | ||
Comment 9•12 years ago
|
||
For Input.keyMap? Yeah I'll do that. Not sure where else you see that it could be used. The real problem was loading additional modules too early.
Reporter | ||
Comment 10•12 years ago
|
||
(In reply to comment #9)
> For Input.keyMap? Yeah I'll do that. Not sure where else you see that it could
> be used. The real problem was loading additional modules too early.
I was talking about the Cu.import's.
Updated•12 years ago
|
tracking-fennec: ? → +
Assignee | ||
Comment 11•12 years ago
|
||
Here is a more cleaned up version, ready for review. Makes things much much faster.
Attachment #677230 -
Attachment is obsolete: true
Attachment #678295 -
Flags: review?(dbolter)
Updated•12 years ago
|
Attachment #678295 -
Flags: review?(dbolter) → review+
Assignee | ||
Comment 12•12 years ago
|
||
Comment 13•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•