Closed Bug 807315 Opened 12 years ago Closed 12 years ago

[AccessFu] We spend 15ms running AccessFu.jsm on mobile startup

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(fennec+)

Status:
RESOLVED FIXED
Milestone:
Firefox 19
Tracking Flags:
Tracking Status
fennec + ---

People

(Reporter: ehsan.akhgari, Assigned: eeejay)

References

Details

(Keywords: perf)

Attachments

(1 file, 1 obsolete file)

Load AccessFu resources on-demand.
(deleted), patch
davidb
: review+
Details | Diff | Splinter Review
Over to Eitan. Ehsan did you have accessibility settings turned on on android?
Assignee: dbolter → eitan
Keywords: perf
Summary: We spend 15ms running AccessFu.jsm on mobile startup → [AccessFu] We spend 15ms running AccessFu.jsm on mobile startup
Blocks: 807322
I grabbed the profile. I didn't opt into anything. How do I check?
OS: Mac OS X → Android
Hardware: x86 → ARM
Update: accessibility setting was not enabled AFAICT
tracking-fennec: --- → ?
Is there such a thing as an acceptable amount of time?
(In reply to comment #4) > Is there such a thing as an acceptable amount of time? Yes, 0. ;-)
Fair enough :)
Attached patch WIP (obsolete) (deleted) — — Splinter Review
Here is the profile before: http://people.mozilla.com/~bgirard/cleopatra/?report=298ba1521e337073883f9e7857e5ea7119e64b83 Here it is after: http://people.mozilla.com/~bgirard/cleopatra/?report=0a4abc01084588a58c88a4848467df61e03e09ec I'm still new to this tool. But it looks like startup in AccessFu dropped from 27ms to 2ms, not quite 0 :) Need to test this patch further to make sure it does not break stuff.
Couldn't you just replace these with lazy getters?
For Input.keyMap? Yeah I'll do that. Not sure where else you see that it could be used. The real problem was loading additional modules too early.
(In reply to comment #9) > For Input.keyMap? Yeah I'll do that. Not sure where else you see that it could > be used. The real problem was loading additional modules too early. I was talking about the Cu.import's.
tracking-fennec: ? → +
Here is a more cleaned up version, ready for review. Makes things much much faster.
Attachment #677230 - Attachment is obsolete: true
Attachment #678295 - Flags: review?(dbolter)
Attachment #678295 - Flags: review?(dbolter) → review+
https://hg.mozilla.org/mozilla-central/rev/0dea4f9a9133
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: