Closed Bug 807404 Opened 12 years ago Closed 12 years ago

Forward button slides in when switching tabs

Categories

(Firefox :: Tabbed Browser, defect)

Product:
Firefox
Component:
Tabbed Browser
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 19
Tracking Flags:
Tracking Status
firefox16 --- unaffected
firefox17 --- unaffected
firefox18 --- unaffected

People

(Reporter: dao, Assigned: dao)

References

Details

(Keywords: regression)

Attachments

(1 file)

patch
(deleted), patch
enndeakin
: review+
Details | Diff | Splinter Review
When switching from a tab with the forward hidden to one with the forward button shown, the forward button should appear immediately. Instead it slides in. This is a regression.
I suspect this is fallout from bug 792296... i.e. we don't flush layout in updateCurrentBrowser between setting and removing the "switchingtabs" attribute.
Regression window(m-i) Good: http://hg.mozilla.org/integration/mozilla-inbound/rev/b8214dfa2924 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:19.0) Gecko/19.0 Firefox/19.0 ID:20121023051209 Bad: http://hg.mozilla.org/integration/mozilla-inbound/rev/3d0fe5f0aa25 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:19.0) Gecko/19.0 Firefox/19.0 ID:20121023051308 Pushlog; http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=b8214dfa2924&tochange=3d0fe5f0aa25
Blocks: 792296
No longer blocks: tabswitch
Component: Toolbars → Tabbed Browser
Keywords: regressionwindow-wanted
Attached patch patch (deleted) — — Splinter Review
Assignee: nobody → dao
Status: NEW → ASSIGNED
Attachment #677235 - Flags: review?(enndeakin)
Attachment #677235 - Flags: review?(enndeakin) → review+
https://hg.mozilla.org/mozilla-central/rev/7e0cf40143ea
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: