Closed
Bug 807465
Opened 12 years ago
Closed 12 years ago
Less QIs in nsXULPopupManager::UpdateMenuItems
Categories
(Core :: XUL, defect)
Core
XUL
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: Ms2ger, Assigned: Ms2ger)
Details
Attachments
(1 file)
|
(deleted),
patch
|
enndeakin
:
review+
|
Details | Diff | Splinter Review |
There is no point in using nsIDOM* interfaces here.
Attachment #677156 -
Flags: review?
|
Assignee | |
Updated•12 years ago
|
Attachment #677156 -
Flags: review? → review?(enndeakin)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 677156 [details] [diff] [review]
Patch v1
>+ nsRefPtr<dom::Element> commandElt = document->GetElementById(command);
>+ if (commandElement) {
You meant to assign to 'commandElement' not 'commandElt'.
|
|
Assignee | |
Comment 2•12 years ago
|
||
Yes, I did. Looks like I forgot to refresh my patch after fixing that.
|
|
||
Comment 3•12 years ago
|
||
Comment on attachment 677156 [details] [diff] [review]
Patch v1
This is ok then assuming that change gets made.
Attachment #677156 -
Flags: review?(enndeakin) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
|
||
Comment 5•7 years ago
|
||
Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336
Component: XP Toolkit/Widgets: XUL → XUL
You need to log in
before you can comment on or make changes to this bug.
Description
•