Closed
Bug 807526
Opened 12 years ago
Closed 12 years ago
Implement GainNode
Categories
(Core :: Web Audio, defect)
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•12 years ago
|
||
|
||
Comment 2•12 years ago
|
||
Comment on attachment 677223 [details] [diff] [review]
Patch (v1)
We could annotate Gain() as retuning a non-addrefed pointer in Bindings.conf, if desired.
Looks fine, but at some point don't we need something that actually does some work if the value on that AudioParam is changed?
Attachment #677223 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
(In reply to Boris Zbarsky (:bz) from comment #2)
> Comment on attachment 677223 [details] [diff] [review]
> Patch (v1)
>
> We could annotate Gain() as retuning a non-addrefed pointer in
> Bindings.conf, if desired.
OK, I'll do that.
> Looks fine, but at some point don't we need something that actually does
> some work if the value on that AudioParam is changed?
Yes, but I'd like to delay doing that until the API is hooked up to mediastreams, which is under progress by roc.
|
|
Assignee | |
Comment 4•12 years ago
|
||
|
||
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
|
|
Assignee | |
Comment 6•11 years ago
|
||
Mass moving Web Audio bugs to the Web Audio component. Filter on duckityduck.
Component: Video/Audio → Web Audio
You need to log in
before you can comment on or make changes to this bug.
Description
•