Comment on attachment 677231 [details] [diff] [review] Patch (v1) >+++ b/content/media/webaudio/AudioContext.cpp >+AudioContext::CreateDelay(const Optional<float>& aMaxDelayTime) I think the spec here is bogus. The IDL should say: DelayNode createDelay(optional double maxDelayTime = 1.0); instead of describing the behavior in prose and making you implement it in C++. Again, we could annotate DelayTime as returning a weak ref. And again, at some point we need to have something actually happen when the mDelay's value is changed, right? r=me modulo all that.

(In reply to Boris Zbarsky (:bz) from comment #2) > Comment on attachment 677231 [details] [diff] [review] > Patch (v1) > > >+++ b/content/media/webaudio/AudioContext.cpp > >+AudioContext::CreateDelay(const Optional<float>& aMaxDelayTime) > > I think the spec here is bogus. The IDL should say: > > DelayNode createDelay(optional double maxDelayTime = 1.0); > > instead of describing the behavior in prose and making you implement it in > C++. Right. I raised this yesterday at the spec level (https://www.w3.org/Bugs/Public/show_bug.cgi?id=19808) and I just changed the spec to do this, so I'll change my code here accordingly. > Again, we could annotate DelayTime as returning a weak ref. Will do. > And again, at > some point we need to have something actually happen when the mDelay's value > is changed, right? Yes, hopefully very soon!

Mass moving Web Audio bugs to the Web Audio component. Filter on duckityduck.