STR: 1. Make sure plugins.click_to_play pref is set on TRUE in about:config 2. Open http://www.youtube.com/ 3. Click on a video 4. Click on the plugin icon in the location bar 5. Choose to "Never activate plugins for this site" 6. Click on the video screen Expected results: The video should not play (or hide the click-to-play UI altogether) Actual results: The video starts playing

Fixing this bug will fix test13b in suite/browser/test/browser/browser_pluginnotification.js

> Fixing this bug will fix test13b in suite/browser/test/browser/browser_pluginnotification.js This seems to work.

Comment on attachment 696063 [details] [diff] [review] Patch v1.0 Proposed fix. Per IRC this is the wrong patch, Philip will attach a new one.

I can't get the tests to work. Frank, any ideas? INFO TEST-START | Shutdown Browser Chrome Test Summary Passed: 16 Failed: 6 Todo: 0 INFO | runtests.py | Running tests: end. mochitest-browser-chrome failed: TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/suite/browser/test/browser_pluginnotification.js | Test 3, plugin fallback type should be PLUGIN_DISABLED - Got 1, expected 2 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/suite/browser/test/browser_pluginnotification.js | Test 3, found 'manage' link in plugin-problem binding TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/suite/browser/test/browser_pluginnotification.js | uncaught exception - TypeError: aTarget is null at chrome://mochikit/content/tests/SimpleTest/EventUtils.js:276 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/suite/browser/test/browser_pluginnotification.js | Test timed out TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/suite/browser/test/browser_pluginnotification.js | Found a tab after previous test timed out: chrome://mochitests/content/browser/suite/browser/test/plugin_test.html TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/suite/browser/test/browser_pluginnotification.js | uncaught exception - ReferenceError: executeSoon is not defined at chrome://mochitests/content/browser/suite/browser/test/browser_pluginnotification.js:88 c:\t1\hg\comm-central\suite\build.mk:78:0: command 'errors=`grep "TEST-UNEXPECTED-" mochitest-browser-chrome.log` ; if test "$errors" ; then echo "mochitest-browser-chrome failed:"; echo "$errors"; exit 1; fi' failed, return code 1 c:\t1\hg\objdir-sm\Makefile:52:0: command 'c:/DEV/mozilla-build/python/python.exe c:/t1/hg/comm-central/mozilla/build/pymake/pymake/../make.py -C mozilla mochitest-browser-chrome' failed, return code 2

Philip: Did you only run the browser_pluginnotification.js test or the whole mochitest-browser-chrome test suite? Just wondering as for me only test12c and test18e fail with your patch applied (those two tests also fail without your patch).

Comment on attachment 701830 [details] [diff] [review] Patch v1.1 > Philip: Did you only run the browser_pluginnotification.js test or the whole > mochitest-browser-chrome test suite? Just wondering as for me only test12c and I only ran browser_pluginnotification.js. > test18e fail with your patch applied (those two tests also fail without your > patch) Hmm. must be something local to me then. If only two tests fail for you with or without my patch I think it should be OK. Switching f? to r?

Comment on attachment 701830 [details] [diff] [review] Patch v1.1 r+, but add a semicolon here: + var doc = this.activeBrowser.contentWindow.document (though the code also works without the semicolon).

Pushed to comm-central: http://hg.mozilla.org/comm-central/rev/d974df0945d3