Closed
Bug 807715
Opened 12 years ago
Closed 12 years ago
BaselineCompiler: support arguments
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
djvj
:
review+
|
Details | Diff | Splinter Review |
I was working on cleaning up/documenting the frame layout and some basic support for arguments helps test some assumptions.
Attachment #677463 -
Flags: review?(kvijayan)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 677463 [details] [diff] [review]
Patch
Review of attachment 677463 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/ion/BaselineFrameInfo.h
@@ +189,5 @@
> + uint32_t nlocals() const {
> + return script->nfixed;
> + }
> + uint32_t nargs() const {
> + return script->function()->nargs;
We probably want to JS_ASSERT that the script has a function - to ensure that nargs() never gets called inadvertently for compilations of top-level scripts.
Attachment #677463 -
Flags: review?(kvijayan) → review+
|
Assignee | |
Comment 2•12 years ago
|
||
Pushed (we usually don't assert non-NULL right before a dereference since it's going to crash immediately).
http://hg.mozilla.org/projects/ionmonkey/rev/6968bdb0417b
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•