Closed
Bug 80807
Opened 24 years ago
Closed 23 years ago
Composer should have only 1 menu item for Find & Replace
Categories
(Core :: DOM: Editor, defect, P3)
Core
DOM: Editor
Tracking
()
VERIFIED
FIXED
mozilla0.9.2
People
(Reporter: Brade, Assigned: cmanske)
References
()
Details
(Whiteboard: fixed)
Attachments
(3 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
Composer should have only one menu item for Find and Replace...
Right now there are two menu items under the Edit menu that do exactly the same
thing. This is very confusing.
Assignee | ||
Comment 1•24 years ago
|
||
Yuck! I agree. Seems like we should do this for 6.5 (there's one more chance
to make UI string changes, according to Robin.) Setting to 0.9.2
The current "Find" should be something like "Find / Replace..." or
"Find & Replace..."
Any preferences?
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.2
Comment 2•24 years ago
|
||
'Find and Replace'
Assignee | ||
Comment 4•24 years ago
|
||
So we need to wait for the "checkin window" before final UI freeze to check this
in, correct (i.e., can't do it now)?
Updated•23 years ago
|
Comment 5•23 years ago
|
||
Assignee | ||
Comment 6•23 years ago
|
||
Thanks, Ryan
r=cmanske
Assignee | ||
Updated•23 years ago
|
Whiteboard: [ui] → [ui] FIX IN HAND need sr=
Reporter | ||
Comment 7•23 years ago
|
||
these fixes should certainly go in, but don't we need to fix mail compose too?
I think we need to change these files:
ComposerCommands.js --> remove nsReplaceCommand & registration of cmd_replace
MsgComposeCommands.js --> remove 3 lines which reference cmd_replace
messengercomposer.xul --> remove menu item
Comment 8•23 years ago
|
||
Comment 9•23 years ago
|
||
Updated•23 years ago
|
Whiteboard: [ui] FIX IN HAND need sr= → [ui] FIX IN HAND need r=, sr=
Comment 10•23 years ago
|
||
sr=sfraser. cc kerz to check that other users of editor in the commercial tree
are OK.
Updated•23 years ago
|
Whiteboard: [ui] FIX IN HAND need r=, sr= → [ui] FIX IN HAND need r=
Comment 11•23 years ago
|
||
looks great
r=anthonyd
Updated•23 years ago
|
Whiteboard: [ui] FIX IN HAND need r=
Comment 12•23 years ago
|
||
a= asa@mozilla.org for checkin to 0.9.1
Comment 13•23 years ago
|
||
Ryan wanted me to check this in for him, but apparently the mailnews part of the
patch is un-sr='ed.
cc sspitzer for review. I won't check this in (yet?).
Assignee | ||
Updated•23 years ago
|
Comment 14•23 years ago
|
||
assuming it's ok with jglick, sr=sspitzer
jglick, if it is ok can you update the spec?
http://www.mozilla.org/mailnews/specs/compose/Comp_Menus.html
Assignee | ||
Updated•23 years ago
|
Whiteboard: FIX IN HAND need sr= → FIX IN HAND
Comment 15•23 years ago
|
||
a= asa@mozilla.org for checkin to the trunk.
(on behalf of drivers)
Updated•23 years ago
|
Whiteboard: FIX IN HAND → fixed, reviewed, a=asa
Assignee | ||
Comment 16•23 years ago
|
||
checked in.
Comment 17•23 years ago
|
||
Updated spec on its way...
You need to log in
before you can comment on or make changes to this bug.
Description
•