Closed Bug 80807 Opened 24 years ago Closed 23 years ago

Composer should have only 1 menu item for Find & Replace

Categories

(Core :: DOM: Editor, defect, P3)

defect

Tracking

()

VERIFIED FIXED
mozilla0.9.2

People

(Reporter: Brade, Assigned: cmanske)

References

()

Details

(Whiteboard: fixed)

Attachments

(3 files)

Composer should have only one menu item for Find and Replace... Right now there are two menu items under the Edit menu that do exactly the same thing. This is very confusing.
Yuck! I agree. Seems like we should do this for 6.5 (there's one more chance to make UI string changes, according to Robin.) Setting to 0.9.2 The current "Find" should be something like "Find / Replace..." or "Find & Replace..." Any preferences?
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.2
'Find and Replace'
Either "Find and Replace..." or "Find & Replace..."
So we need to wait for the "checkin window" before final UI freeze to check this in, correct (i.e., can't do it now)?
Keywords: correctness
Priority: -- → P3
Whiteboard: [ui]
Attached patch Patch for bug (deleted) — Splinter Review
Thanks, Ryan r=cmanske
Whiteboard: [ui] → [ui] FIX IN HAND need sr=
these fixes should certainly go in, but don't we need to fix mail compose too? I think we need to change these files: ComposerCommands.js --> remove nsReplaceCommand & registration of cmd_replace MsgComposeCommands.js --> remove 3 lines which reference cmd_replace messengercomposer.xul --> remove menu item
Whiteboard: [ui] FIX IN HAND need sr= → [ui] FIX IN HAND need r=, sr=
sr=sfraser. cc kerz to check that other users of editor in the commercial tree are OK.
Whiteboard: [ui] FIX IN HAND need r=, sr= → [ui] FIX IN HAND need r=
looks great r=anthonyd
Whiteboard: [ui] FIX IN HAND need r=
a= asa@mozilla.org for checkin to 0.9.1
Ryan wanted me to check this in for him, but apparently the mailnews part of the patch is un-sr='ed. cc sspitzer for review. I won't check this in (yet?).
Keywords: patch, review
Whiteboard: FIX IN HAND need sr=
assuming it's ok with jglick, sr=sspitzer jglick, if it is ok can you update the spec? http://www.mozilla.org/mailnews/specs/compose/Comp_Menus.html
Whiteboard: FIX IN HAND need sr= → FIX IN HAND
Blocks: 83989
a= asa@mozilla.org for checkin to the trunk. (on behalf of drivers)
Whiteboard: FIX IN HAND → fixed, reviewed, a=asa
checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Keywords: patch, review
Resolution: --- → FIXED
Whiteboard: fixed, reviewed, a=asa → fixed
Updated spec on its way...
verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: