Closed Bug 80833 Opened 24 years ago Closed 23 years ago

Every other bookmark does not get deleted when attempting to delete multiple bookmarks

Categories

(SeaMonkey :: Bookmarks & History, defect, P2)

defect

Tracking

(Not tracked)

VERIFIED FIXED
mozilla0.9.2

People

(Reporter: jonrubin, Assigned: bugs)

References

Details

(Whiteboard: Patch reviewed, super-reviewed. Needs a=)

Attachments

(1 file)

Found in 2001050706 trunk build on WinMe-ja; reproduced on Win98-en using 2001042506 trunk build. When selecting a list of bookmarks to delete in "Manage Bookmarks", every other bookmark fails to get deleted. Steps: 1) Create several bookmarks (i.e. 6 total). 2) In "Manage Bookmarks", select all of the bookmarks you just created and Delete them (rt-click, select delete). 3) The bookmarks no longer appear in the "Manage Bookmarks" list; however, half of the bookmarks still appear when selecting "Bookmarks" from the menu (so if 6 bookmarks were originally added, the 2nd, 4th, and last bookmark are still there). Closing "Manage Bookmarks" and reopening results in the undeleted bookmarks appearing there too.
Priority: -- → P3
This is rather embarrassing, and I know what's going on. Need for rtm.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.2
Yes, this sucks. Adding nsbeta1 keyword.
Keywords: nsbeta1
Here the same problem (PC, WinME, Build 2001052404).
*** Bug 82847 has been marked as a duplicate of this bug. ***
X-Platform bug.
OS: Windows ME → All
Hardware: PC → All
Confirmed on Win2K, build 20010505.
boink
Priority: P3 → P2
Confirmed on Linux RH6.2-Ja, build 2001052205.
Keywords: nsbeta1nsbeta1+
*** Bug 77161 has been marked as a duplicate of this bug. ***
Patch: - no need to increment |count| as we remove each item from the array as we process it (I believe this bug was introduced at a point where aSelection changed from an immutable nodelist to a mutable jsarray). - also, shift the removal until after the code that forcably removes the node from the document. the try .. catch was likely shielding a js error that must have been occurring here.
Whiteboard: Patch ready. Needs r=, sr=
sr=blake
Whiteboard: Patch ready. Needs r=, sr= → Patch ready. Needs r=, a=
Whiteboard: Patch ready. Needs r=, a= → Patch reviewed, super-reviewed. Needs a=
r=jag
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Blocks: 83989
VERIFIED Fixed with 2001061514 builds
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: