If you have localhost in your noproxyfor list, and your plugin requests the url http://localhost:8080/ using FindProxyForURL, ExamineForProxy should not return NS_OK. Currently it does.

qa to me. Please describe the proxy settings you have, or paste in all the "network.proxy.*" preferences from prefs.js. "No Proxy for:" works only with manual config, not with Proxy Auto Config (PAC).

(last comment should have been as "benc@netscape.com". must be working too many mornings...)

On 15 May 15:53:26, Peter Lubczynski wrote: > > Ed, the reason I ask for the Zero port is that your patch doesn't seem to > include it: > > + if (!isProxyEnabled || !proxyHost.get() || proxyPort < 0) { > *result = PL_strdup("DIRECT"); > > Should that be less than or equal to zero? Yes, it should be <= 0.

Benc: NO PAC here. HTTP, FTP, GOPHER, SSL proxy webcache-cup.eng.sun.com 8080 no proxy for 127.0.0.1,localhost

r=peterl

sr=darin

Why do we need to check |!isProxyEnabled| at _all_ here? The previous test will have returned if |!isProxyEnabled|, and nobody mutates or aliases the value in between.

fix checked in by edburns@acm.org

The fix I checked in isn't really a fix, it just corrects the symptom in a non- hackish way. The real fix would be to make it so nsProtocolProxy->ExamineForProxy() returns failure whenever the host or port returned is invalid. Re-opening.

gagan wants it! :)

Please provide the problem description the way an end user would describe it... Are you saying that you do not want proxy for localhost (like http://localhost), and entering "localhost" in "No Proxy for:" is still causing it to proxy?

I disagree with ed. A null host is a valid way of returning "no proxy" information. The return value of that function is indicating whether the call itself succeeded NOT whether there is a proxy for a specified uri or not. So a caller of ExamineForProxy should always check the values of host/port before using them. So I think your fix is correct. closing this.

verified