Pablo Sanchez [:pabloUX] Reporter
	Description • 12 years ago

VAlue selectors should be as it is specified in tbe BB.

	ayman maat :maat
	Comment 1 • 12 years ago

yes they should. including Steve P on this as i feel it is more a visual design touchpoint.

	Josh Carpenter [:jcarpenter]
	Comment 2 • 12 years ago

Just FYI: There's a relevant bug on this, here: https://bugzilla.mozilla.org/show_bug.cgi?id=818359

Rafa and Sergi were also cc'd on the parallel email thread, subject: "The behavior of value selector has been changed". We had to shift how value selectors work in v1 for technical reasons.

	Paco Rampas [:paco]
	Comment 5 • 10 years ago

Comment on attachment 8515817 [details]
patch in github

Hello,

We are working for applying the value selector for contacts. We have attached a screenshot with the after and before. With this patch is all working fine but there is a error: "mozL10n: A non-existing entity requested: #type_l10n_id#" when the edit mode is opened. We couldn't find the issue, could you help us?
Also, could you give us your feedback about the patch in general?

Thanks.

	Francisco Jordano [:arcturus] [:francisco]
	Comment 6 • 10 years ago

Comment on attachment 8515817 [details]
patch in github

Jose I'm a bit overloaded, could you take a look?

Specially to the critical path, I think we will be loading more resources at startup and that can penalize our cold start time.

	Jose Manuel Cantera
	Comment 7 • 10 years ago

Comment on attachment 8515817 [details]
patch in github

This patch news much more work on various aspects:

A/ Carrie and Fang to give us the ok to the interaction and visual proposal you are making here. 

B/ If they give us the ok, then you should file a new bug to modify building blocks.

C/ The concerned CSS files to implement that design should be lazy loaded

D/ I left other substantive comments on GH, concerning the code organization

thanks Paco. needinfo-ing Carrie and Fang to know their opinions

	Carrie Wang [New account: carrie75521@gmail.com]
	Comment 8 • 10 years ago

Hi, 

I wonder what's the difference between the attached pic and the current implementation on my device (master build)? It's using the correct bb on my flame already (looks exactly the same as your "After"). Thanks!

	Paco Rampas [:paco]
	Comment 9 • 10 years ago

Excuse me carrie, you are right in comment 8. The after was before and before was after hehehe. I have updated the screenshot with correct after/before label.

	Fang Shih [:fang]
	Comment 10 • 10 years ago

ni? Harly for building block issue. Thanks!

	Carrie Wang [New account: carrie75521@gmail.com]
	Comment 11 • 10 years ago

Comment on attachment 8518824 [details]
object-menu-contacts.png

The input field is not following the building block. We need Harly's input on this one. Thanks!

	Harly Hsu[:harly]
	Comment 12 • 10 years ago

After discussion with the Framework team, since currently we don't have "value selector with input field as an item" in our standard Building Blocks. Therefore, it is not suggested to make a hack version of value selector. The team proposed to use a standard value selector, and when user taps "Custom", it will trigger an input dialog for user to input custom tag name.

	Arnau March [:arnau] ( not working in Firefox OS anymore :( )
	Comment 13 • 10 years ago

Hey Harly, could you please review that again with the framework team?
Please check: http://buildingfirefoxos.com/building-blocks/object-menu.html (3rd example: inputs)

As we discussed in the past value selectors and action menus are to strict, so we created object menu as a way to implement more flexible modal structures.

	Harly Hsu[:harly]
	Comment 14 • 10 years ago

Hi Arnau, 
Thanks for bringing this up. Currently in our Building Blocks, it is defined that Object menus are accessed using a "press-and-hold" gesture on a selectable object (https://developer.mozilla.org/en-US/Apps/Design/Firefox_OS_building_blocks/1.x/Object_menu). Which in this case, doesn't fit this scenario. Also, due to the fact that in the edit contact page, the "Home", "Personal" and "Birthday" fields all use a triangle at the bottom right corner to indicate that it should trigger a value selector when pressed(please refer to the attach screenshot). Therefore, the Framework team suggested that it should trigger a value selector first, and then when user selects "Custom", it then opens an input dialog for user to input custom tag. Hope this answer your question.

	Arnau March [:arnau] ( not working in Firefox OS anymore :( )
	Comment 15 • 10 years ago

Cool.
Paco, you should create a new patch following Harly's comment, please.

	Paco Rampas [:paco]
	Comment 17 • 10 years ago

Comment on attachment 8529032 [details]
alertCustom.png

Hi Harly,

Regarding your comment 12, could you check if you want this?

Thanks

	Harly Hsu[:harly]
	Comment 18 • 10 years ago

Hi Paco,
Thank you for making the modification, I just have 2 comments here:
1. Are you using a standard value selector like the one defined here (http://buildingfirefoxos.com/building-blocks/value-selector.html)? Because, typically a single select value selector will only have a cancel button at the bottom, but the screenshot you've provided have cancel and done button. 

2. Another thing is that could you remove the chevron (>) on the right side of create custom? We don't really a pattern of a chevron within value selector now.

Thanks

	Paco Rampas [:paco]
	Comment 20 • 10 years ago

Comment on attachment 8529698 [details]
tag-select-contacts.png

Hi, could you recheck this?
Thanks.

	Harly Hsu[:harly]
	Comment 21 • 10 years ago

Paco, all looks good to me, I just have one question. After tapping the done button in "edit custom" page, does it go back to the edit contact page? or the "custom selected" page?

	Paco Rampas [:paco]
	Comment 22 • 10 years ago

(In reply to Harly Hsu from comment #21)
> Paco, all looks good to me, I just have one question. After tapping the done
> button in "edit custom" page, does it go back to the edit contact page? or
> the "custom selected" page?
You go back to "edit contact page". Is it ok?

	Harly Hsu[:harly]
	Comment 23 • 10 years ago

Comment on attachment 8529698 [details]
tag-select-contacts.png

Yes, that's just what I wanted. Thanks.

	Paco Rampas [:paco]
	Comment 25 • 10 years ago

Comment on attachment 8532518 [details]
patch in github v2

Hi Cantera, could you review this?

	Tiffanie Shakespeare [:tif]
	Comment 26 • 9 years ago

Harly - do you know if this is still an issue? Thanks!

	Harly Hsu[:harly]
	Comment 27 • 9 years ago

Hi Tiff, the issue still exists in the current contact app.

	BMO Automation
	Comment 28 • 6 years ago

Firefox OS is not being worked on