David Flanagan [:djf] Assignee
	Description • 12 years ago

We don't have room on the phone for all the keyboard input method dictionaries that we'd like.  Months ago we removed a bunch of european dictionaries because we were out of space.  But now we've got a phone targeting latin america with no spanish dictionary.

We've got three input methods (and dictionaries) for asian languages, but according to https://bugzilla.mozilla.org/show_bug.cgi?id=796484 they cause OOM errors and crash the phone (because keyboard runs in process).

I propose, therefore, to remove the Asian IMs and their dictionaries and add a spanish dictionary.  (Are there other European dictionaries we should add as well? We already have french, german and Brazilian portuguese.)

	David Flanagan [:djf] Assignee
	Comment 1 • 12 years ago

cc'ing Andreas, Chris, Chris, and Rudy. Are you guys okay with this plan?  Do we need other languages besides spanish?

Take a look at the files in gaia/dicitonaries/ for the options I know about.  Note that we just have generic spanish, not country-specific dictionaries for latin america.

We also have dictionaries for cs, en_gb, hr, it, nb, and pt_pt available.  I'm not sure what all of those countries are.  Andreas: are these the only sets of wordlists from Android, or are there more available if we want them?

	David Flanagan [:djf] Assignee
	Comment 2 • 12 years ago

Nominating blocking because we really need to free up space on the phone, and we really need some spanish support.

	David Flanagan [:djf] Assignee
	Comment 3 • 12 years ago

On the other hand, it is really nice to be able to demo asian input on the phone.  Rudy says we need to retain at least one of the Chinese IMs.

If I just delete the Japanese IM, we free up 3.9mb. If I add spanish, I expect that to add 2.4mb.  Do we need German? 

Maybe we can modify the IMs so that they will look on the sdcard for dictionaries in addition to looking locally.  So if we want to demo in another language, we can just push the required dictionaries to the card.

	Rudy Lu [:rudyl] (inactive after 2015/7/3)
	Comment 4 • 12 years ago

For Bug 796484, we moved the settings of Asian IMEs to developer section so that we could enable them for demo/testing purposes while they may cause OOM issues. 

If we want to save more storage space for this, we could remove all dictionary files for Asian IMEs for now.
And re-build the dictionaries for demo/testing when necessary.

+cc James Ho for any opinions on this.

	James Ho
	Comment 5 • 12 years ago

Agreed with Rudy in comment#4

	Alex Keybl [:akeybl]
	Comment 6 • 12 years ago

Milestoning for C2 (deadline of 12/10), as this meets the criteria of "remaining P1 bugs not already milestoned for C1".

	Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)
	Comment 7 • 12 years ago

(In reply to Rudy Lu [:rudyl] from comment #4)
> For Bug 796484, we moved the settings of Asian IMEs to developer section so
> that we could enable them for demo/testing purposes while they may cause OOM
> issues. 
> 
> If we want to save more storage space for this, we could remove all
> dictionary files for Asian IMEs for now.

Maybe those could be hidden behing an option at compile time?

> And re-build the dictionaries for demo/testing when necessary.
> 
> +cc James Ho for any opinions on this.

	David Flanagan [:djf] Assignee
	Comment 8 • 12 years ago

Adding the spanish dictionary is easy. I'm a little nervous about removing the Asian dictionaries, since we haven't agreed on which ones to remove and how they'd be re-enabled for demos.

Chris: is there room on the device for me to just add Spanish (~2.4mb) without removing any Asian dictionaries?

James and Rudy: how about I just remove the Kanji dictionary and leave both Chinese dicationaries on the device. Does that sound okay?

	David Flanagan [:djf] Assignee
	Comment 9 • 12 years ago

Rudy would you review this change, please?

	David Flanagan [:djf] Assignee
	Comment 10 • 12 years ago

I've attached a patch that adds spanish and removes japanese.

I don't understand the new localization system, though. It is no longer possible for me to select Spanish as my language, so I can't test that spanish word suggestions are being offered.

Stas: if you create a build for Spanish-speaking testers, you might want to apply the attached pull request if it hasn't landed yet.

	Rudy Lu [:rudyl] (inactive after 2015/7/3)
	Comment 11 • 12 years ago

Comment on attachment 685768 [details]
link to github pull request

Hi David,

I think we can remove all the dictionaries, including the 2 for Chinese now to save more space.

r+, please let me know if you need me to do it as a follow up.
Thanks for your help.

	David Flanagan [:djf] Assignee
	Comment 12 • 12 years ago

Rudy,

Thanks. I'll file a follow-up bug. I don't know whether we need to delete the two Chinese dictionaries.  What we really need (and I'll put this in the other bug) is a build-time configuration system that integrates keyboard IMs and dictionaries with the locale stuff, so that we can specify the set of supported languages at build time.

	David Flanagan [:djf] Assignee
	Comment 13 • 12 years ago

Followup bug here: https://bugzilla.mozilla.org/show_bug.cgi?id=815966

Closing this one. Note that despite the title, I did not end up removing all the Asian IMs. All I actually did was remove the dictionary file from the jskanji IM and add the spanish dictionary to the latin IM.