STEPS: After configuring PAC, then turning it off, I still see: PAC:Loading PAC from <URL> in Console everytime I start (somewhere after selecting a profile).

fixing summary

-->PAC bugs to Jussi

mass move, v2. qa to me.

this is a debug output, the next patch does comment it out: =================================================================== RCS file: /cvsroot/mozilla/netwerk/base/src/nsProxyAutoConfig.js,v retrieving revision 1.9 diff -u -r1.9 nsProxyAutoConfig.js --- nsProxyAutoConfig.js 2001/04/26 14:06:22 1.9 +++ nsProxyAutoConfig.js 2001/05/30 01:24:53 @@ -70,7 +70,7 @@ var uri = url.QueryInterface(Components.interfaces.nsIURI); // Call the original function- var proxy = LocalFindProxyForURL(uri.spec, uri.host); - debug("Proxy = " + proxy); +// debug("Proxy = " + proxy); if (proxy == "DIRECT") { host.value = null; type.value = "direct"; @@ -89,7 +89,7 @@ }, LoadPACFromURL: function(uri, ioService) { - debug("Loading PAC from " + uri.spec); +// debug("Loading PAC from " + uri.spec); this.done = false; var channel = ioService.newChannelFromURI(uri); pacURL = uri.spec;

*** Bug 83984 has been marked as a duplicate of this bug. ***

Wait! Are you adding code that reads user_pref "network.proxy.type" to see if PAC should be read, or are you just hiding the debug comments? The debug comments are good, the behavior is what is bad.

I do not see "PAC:Loading PAC from <URL>" message on linux 2001060408 release build when I turnning of the proxy using Preferences->Advanced->Proxies dialog, and restart.

I'm not getting enough sleep. It happens in Mozilla 0.9 for Win32. I'll check an newer build. You should check the dupe to what they say, and Asa says it happens on the trunk.

Ignore previous commments, they went to the wrong bug... Is this code checked in? What is the function of this code? The problem here is that PAC loads, even if PAC is not the selected proxy type (direct or manual) The pref is network.proxy.type, and PAC should only load if it is "2"

How do you know that PAC if loaded if network.proxy.type != 2? I cannot reproduce this with latest window & linux builds.

I've been looking at the log file on my proxy server.

now that I think about it more, if you don't see this behavior in the build, and you can verify with a trace or a log file, then mark works for me. I'm going to add this to the network preferences test cases I'm working on, so if it is broken, it will show in the functional test anyhow.

*** This bug has been marked as a duplicate of 85290 ***

This is not a duplicate. If a the action requested in a bug is not clear, please ask for clarification before slamming code into the tree.

Serge, can you take a look at these PAC issues? Thanks - Jussi-Pekka

+ verifyme, makingtest need to test this.

I think this bug is fixed. The trace output has been removed from nsProxyAutoConfig.js. Furthermore, the nsProtocolProxyService code that processes the prefs only loads the PAC file if the "type" is 2 (= autoproxy). See http://lxr.mozilla.org/mozilla/source/netwerk/base/src/nsProtocolProxyService.cpp#225 I'd like to shut this bug down.

If you think this is good, then I'm okay with you marking it resolved.

Marking fixed.

mass remove verifyme requests greater than 4 months old