José Antonio Olivera Ortega [:jaoo] Assignee
	Description • 12 years ago

We have to enable Latin characters replacement with corresponding ones in GSM SMS 7-bit default alphabet through the setting API.

	José Antonio Olivera Ortega [:jaoo] Assignee
	Comment 1 • 12 years ago

Exposing the `strict7BitEncoding` setting through the settings API.

	Vicamo Yang [:vicamo][:vyang]
	Comment 2 • 12 years ago

Comment on attachment 678787 [details] [diff] [review]
v1

Review of attachment 678787 [details] [diff] [review]:
-----------------------------------------------------------------

Bug 804960 comment #19 from Mounir, maybe we can simply mirror the settings entry back to preference:

  ::in gecko/b2g/chrome/content/settings.js
  SettingsListener.observe('ril.sms.strict7BitEncoding.enabled', false, function(value) {
    Services.prefs.setBoolPref('dom.sms.strict7BitEncoding', value);
  }

	José Antonio Olivera Ortega [:jaoo] Assignee
	Comment 3 • 12 years ago

Mirror the settings entry back to preference. Much more easier. Thx Vicamo!

	Vicamo Yang [:vicamo][:vyang]
	Comment 4 • 12 years ago

Comment on attachment 678856 [details] [diff] [review]
v2

Review of attachment 678856 [details] [diff] [review]:
-----------------------------------------------------------------

Nice Job!

	José Antonio Olivera Ortega [:jaoo] Assignee
	Comment 5 • 12 years ago

Hey Dietrich, could you please review the blocking-basecamp nomination for this bug?, the work from bug 804960 depends on this bug.

	José Antonio Olivera Ortega [:jaoo] Assignee
	Comment 6 • 12 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/7dbd49fe775e

	Ryan VanderMeulen [:RyanVM]
	Comment 7 • 12 years ago

https://hg.mozilla.org/mozilla-central/rev/7dbd49fe775e

	Ryan VanderMeulen [:RyanVM]
	Comment 8 • 12 years ago

https://hg.mozilla.org/releases/mozilla-aurora/rev/c0f1dea03015