Closed
Bug 809028
Opened 12 years ago
Closed 12 years ago
Restarting the app after a different theme was enabled will still display the previous one
Categories
(Firefox for Android Graveyard :: Theme and Visual Design, defect)
Tracking
(firefox19 verified, firefox20 verified)
VERIFIED
FIXED
Firefox 20
People
(Reporter: xti, Assigned: sriram)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
mfinkle
:
review+
akeybl
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Firefox 19.0a1 (2012-11-06)
Device: Galaxy S2
OS: Android 4.0.3
Steps to reproduce:
1. Go to http://www.getpersonas.com/en-US/ and add a couple of themes
2. Go to about:addons (Menu > Tools > Add-ons)
3. Tap on a grayed out theme and enable it
4. Restart app
Expected result:
The enabled theme at step 3 is displayed.
Actual result:
The same theme that is was active before step 3, is still displayed after restart.
|
||
Updated•12 years ago
|
Assignee: nobody → sriram
|
Assignee | |
Comment 1•12 years ago
|
||
(Did I just fix a bug in Gecko side? :O )
This fixes the addons problem.
Attachment #683262 -
Flags: review?(mark.finkle)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 683262 [details] [diff] [review]
Patch
This looks right to me
Attachment #683262 -
Flags: review?(mark.finkle) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
|
||
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
|
|
||
Comment 5•12 years ago
|
||
Sriram - I assume we want this uplifted to aurora?
status-firefox19:
--- → affected
|
|
Assignee | |
Comment 6•12 years ago
|
||
Comment on attachment 683262 [details] [diff] [review]
Patch
[Approval Request Comment]
Bug caused by (feature/regressing bug #): Very old copy-paste bug between xul and native.
User impact if declined: Personas will be different when user re-opens Fennec.
Testing completed (on m-c, etc.): Landed on 11/29.
Risk to taking this patch (and alternatives if risky): Very low.
String or UUID changes made by this patch: -
Attachment #683262 -
Flags: approval-mozilla-aurora?
|
||
Comment 7•12 years ago
|
||
Comment on attachment 683262 [details] [diff] [review]
Patch
In support of our new theming.
Attachment #683262 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
||
Comment 8•12 years ago
|
||
status-firefox20:
--- → fixed
|
||
Comment 9•12 years ago
|
||
Verified on:
Firefox 20.0a1 (2012-12-07)
Firefox 19.0a2 (2012-12-07)
Device: Galaxy S2
OS: Android 4.0.3
|
|
||
Updated•12 years ago
|
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•