Closed Bug 809055 Opened 12 years ago Closed 7 years ago

Moving Firefox to background while playing a flash video in full screen mode and bring it back to view will freeze the app

Categories

(Firefox for Android Graveyard :: Plugins, defect)

Product:
Firefox for Android Graveyard
Component:
Plugins
Version:
19 Branch
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox18 affected, firefox19 affected, firefox20 verified, firefox21 fixed, firefox22 fixed, firefox23+ wontfix, firefox24+ wontfix, relnote-firefox 23+, fennec-)

Status:
RESOLVED FIXED
Milestone:
Firefox 20
Tracking Flags:
Tracking Status
firefox18 --- affected
firefox19 --- affected
firefox20 --- verified
firefox21 --- fixed
firefox22 --- fixed
firefox23 + wontfix
firefox24 + wontfix
relnote-firefox --- 23+
fennec - ---

People

(Reporter: xti, Assigned: snorp)

References

Details

(Keywords: hang, regression)

Attachments

(1 file)

Restore fullscreen plugins after document becomes active
(deleted), patch
blassey
: review+
Details | Diff | Splinter Review
Firefox 19.0a1 (2012-11-06) Device: Galaxy S2 OS: Android 4.0.3 Steps to reproduce: 1. Go to youtube.com (desktop site) 2. Select a video from the list and play it in full screen mode 3. Tap on device Home button 4. Tap on Firefox shortcut to bring the app back into view Expected result: The app is not longer in full screen mode after step 4. Also no hangs or freezes will occur. Actual result: The app freezes after step 4.
Does this happen on any other video or just youtube? Is this Flash playback or html5 <video>?
tracking-fennec: --- → ?
Flags: needinfo?(nicolae.cristian)
This is happening just for flash playback (on any website). It doesn't occur on any HTML5 video.
Flags: needinfo?(nicolae.cristian) needinfo?(nicolae.cristian) → needinfo+
This issue occurs now on Aurora too, since bug 809005 was fixed. -- Firefox 18.0a2 (2012-11-12) Device: Galaxy S2 OS: Android 4.0.3
status-firefox18: --- → affected
status-firefox19: --- → affected
Summary: Moving Nightly to background while playing a video in full screen mode and bring it back to view will freeze the app → Moving Firefox to background while playing a video in full screen mode and bring it back to view will freeze the app
Summary: Moving Firefox to background while playing a video in full screen mode and bring it back to view will freeze the app → Moving Firefox to background while playing a flash video in full screen mode and bring it back to view will freeze the app
Assignee: nobody → snorp
tracking-fennec: ? → 18+
Snorp, what's your plan here?
Flags: needinfo?(snorp)
Haven't really looked at this closely yet, but if I'd guess it's probably caused by Flash holding a lock while we are blocked in scheduleResumeComposition(), similar to other deadlocks.
Flags: needinfo?(snorp)
I've confirmed that this is caused by the thing I described above (though it's pausing composition, not resuming). Brad and I discussed a possible solution that takes the gecko main loop out of the composition pause process. Basically call nsWindow::SchedulePauseComposition directly from the UI thread.
It turns out we didn't actually have the fullscreen surface displayed, which is why Flash never gave up the lock (it waits on the surface). Attached patch fixes that, and I don't get a deadlock.
Attachment #692412 - Flags: review?(blassey.bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/f773ab3d5146
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
Firefox 20.0a1 (2012-11-19) Device: Galaxy Nexus/ Galaxy Note OS: Android 4.1.1/ 4.0.4 This is not reproducible on latest Nightly following steps from description. Marking bug as VERIFIED FIXED.
Status: RESOLVED → VERIFIED
status-firefox20: --- → verified
Depends on: 827407
Status: VERIFIED → REOPENED
status-firefox21: --- → fixed
status-firefox22: --- → fixed
status-firefox23: --- → fixed
status-firefox24: --- → affected
Resolution: FIXED → ---
Keywords: hang
Severity: normal → critical
status-firefox23: fixed → affected
Snorp, what are your plans for FF23/24 now that this is backed out for bug 827407?
tracking-firefox23: ? → +
tracking-firefox24: ? → +
Keywords: regression
At this point, for FF23 we'll have to wontfix this and make a note in Known Issues.
status-firefox23: affected → wontfix
relnote-firefox: --- → ?
Noted in 'Known Issues'
relnote-firefox: ? → 23+
Next time, I think it would be a good idea to mention that this a mobile-only problem in the "Known Issue" notes. No need to worry users unnecessarily.
^ "Product: Firefox for Android" >_> <_<
needsinfo on :snorp to help with comment 12 given we are only left with two more mobile beta's for Fx24 as well.
Flags: needinfo?(snorp)
At this point, for FF23 we'll have to wontfix this and carry on the note in Known Issues
status-firefox24: affected → wontfix
The fix we had before was correct, IMHO, but I guess it caused some bad Flash behavior (crashing). I haven't had time to look at this or other Flash bugs but hope to soon.
Flags: needinfo?(snorp)
This happens to me several times a day. It is not just on YouTube, it is on all flash or non flash video. If I go to another tab and then go back it is frozen about 80% of the time and nothing you can do will fix it. It can sometimes be prevented by clicking on history clear and clear the cache, but even that does not always work! Just thought I would let you know.
(In reply to Lukas Blakk [:lsblakk] from comment #14) > Noted in 'Known Issues' This should be in 'Mobile' instand of 'Desktop'.
(In reply to Lukas Blakk [:lsblakk] from comment #14) > Noted in 'Known Issues' This bug is still incorrectly listed in the FF 27 desktop release notes, while it is not included in the current mobile release notes.
Flags: needinfo?(lsblakk)
It has happened for me in desktop Firefox 26 also. Not in every switching between fullscreen flash video and Firefox, but if happen to do it multiple times, then it tends to happen. Both in Youtube and in Twitch. Killing plugincontainer helps to unfreeze the Firefox. Windows is Windows XP and it has happend with last couple of flash versions.
> The fix we had before was correct, IMHO, but I guess it caused some bad > Flash behavior (crashing). I haven't had time to look at this or other Flash > bugs but hope to soon. Snorp's been all over Flash lately. Let's entertain the thought to see if Snorp is working on this?
Flags: needinfo?(snorp)
I haven't, but I will.
Flags: needinfo?(snorp)
Why is this bug in the 27.0.1 desktop release notes at https://www.mozilla.org/en-US/firefox/27.0.1/releasenotes/ when it is an Android only bug?
(In reply to Pascal from comment #26) > Why is this bug in the 27.0.1 desktop release notes at > https://www.mozilla.org/en-US/firefox/27.0.1/releasenotes/ when it is an > Android only bug? We asked that question in comment #22. Still waiting for a release manager to make an adjustment.
This has been resolved in our database and in svn for trunk/stage/production notes and should not come back in future versions. http://viewvc.svn.mozilla.org/vc?view=revision&revision=125342
Flags: needinfo?(lsblakk)
clearing obsolete tracking flag due to Bug 1370184 This bug is very likely a resolved one.
tracking-fennec: 18+ → -
Yeah it is
Severity: critical → normal
Status: REOPENED → RESOLVED
Closed: 12 years ago → 7 years ago
Resolution: --- → FIXED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: