Closed
Bug 809109
Opened 12 years ago
Closed 7 years ago
Expose timeout parameter to all devicemanager commands
Categories
(Testing :: Mozbase, defect)
Testing
Mozbase
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: ahal, Assigned: mihneadb)
References
Details
Attachments
(1 file)
(deleted),
patch
|
ahal
:
feedback+
|
Details | Diff | Splinter Review |
In dmADB the _checkCmd method has a timeout parameter that defaults to 300 seconds. But if you call e.g pushFile, there is no way to pass in a custom timeout. We should add the timeout property to all of the various commands that are built on top of _checkCmd.
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → mihneadb
Assignee | ||
Comment 1•12 years ago
|
||
I tried to see if I can pull out the timeout parameter in the abstract dm.py but the dmSUT implementation is quite different with regard to wrapped low level functions (for example even dirExists might end up having a timeout parameter which I'm not sure is desired).
Attachment #691539 -
Flags: feedback?(ahalberstadt)
Reporter | ||
Comment 2•12 years ago
|
||
Comment on attachment 691539 [details] [diff] [review]
add timeout parameter to dmADB methods that use checkCmd
Review of attachment 691539 [details] [diff] [review]:
-----------------------------------------------------------------
This looks good, though I didn't go into the source looking for other missed instances or anything. I don't think there is a burning need for this so feel free to leave it on the backburner unless you want some work to do :)
Attachment #691539 -
Flags: feedback?(ahalberstadt) → feedback+
Comment 3•7 years ago
|
||
Mass closing bugs with no activity in 2+ years. If this bug is important to you, please re-open.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•