Closed Bug 809123 Opened 12 years ago Closed 12 years ago

disable browser_586068-reload.js due to buggy test

Categories

(Firefox :: Session Restore, defect)

All
Windows 8
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: vlad, Assigned: vlad)

References

Details

Attachments

(1 file)

browser_586068-reload.js is causing a lot of intermittent failures, and ends up causing even more (often going perma-orange) with patches that affect timing of various things. Given that it's flaky to begin with, and no other tests show problems with these patches, I suspect there's something in the session store code or this test that's subtly timing dependent. I spent a while looking at it and trying different things, and could never find something that fixed it reliably; however, I was also never able to reproduce the failure locally (tried on four different machines over quite a long period). We should just disable this test until someone who understands the session store code can walk through everything and see where things might be going wrong.
Attached patch disable reload test (deleted) — Splinter Review
Disable this test until we can figure out why it's so fragile.
Attachment #678824 - Flags: review?(ttaubert)
Attachment #678824 - Flags: review?(ted)
Comment on attachment 678824 [details] [diff] [review] disable reload test Review of attachment 678824 [details] [diff] [review]: ----------------------------------------------------------------- Sorry for the hassle that this caused. On the positive side, a constantly failing test should be easier to fix :)
Attachment #678824 - Flags: review?(ttaubert) → review+
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: