Currently |atob| and |btoa| are undefined in xpcshell.

Comment on attachment 679789 [details] [diff] [review] v1 Review of attachment 679789 [details] [diff] [review]: ----------------------------------------------------------------- Two small comments... r+ with them addressed. ::: js/xpconnect/shell/xpcshell.cpp @@ +797,5 @@ > +{ > + if (!argc) > + return true; > + > + return xpc::Base64Decode(cx, JS_ARGV(cx, vp)[0], &JS_RVAL(cx, vp)); Given that you are using namespace xpc above, the xpc:: here is redundant. I'd prefer to nuke the "using" declaration in favor of the explicit xpc:: here (given that you're only using two names out of the namespace). ::: js/xpconnect/src/nsXPConnect.cpp @@ +2322,5 @@ > return nsXPConnect::GetRuntimeInstance()->DeferredRelease(obj); > } > > + > +NS_EXPORT_(bool) Uber-nit: remove the extra newline added above this.

Thanks Blake! https://hg.mozilla.org/integration/mozilla-inbound/rev/a7d7319e532b

Comment on attachment 679789 [details] [diff] [review] v1 We need this fix in order to land navigator.mozPay tests from Bug 809219

Comment on attachment 679789 [details] [diff] [review] v1 approving, in conjunction with bug 809219 so that unittests can be enabled on mozPay