Closed Bug 809275 Opened 12 years ago Closed 12 years ago

[statusbar] add logic to show an icon if there are active downloads

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Platform:
Other
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-basecamp:+)

Status:
RESOLVED FIXED
Project Flags:
blocking-basecamp +

People

(Reporter: julienw, Assigned: julienw)

References

Details

Attachments

(1 file, 3 obsolete files)

patch
(deleted), patch
julienw
: review+
Details | Diff | Splinter Review
when implementing Bug 802605, I want to add some generic code in statusbar.js that will be used by the update-manager as well. This code manages how the "active download" icon is displayed.
Assignee: nobody → felash
Blocks: 802605
Status: NEW → ASSIGNED
Attached patch patch with tests (obsolete) (deleted) — — Splinter Review
honestly I didn't run the tests because I don't know how to do this yet ;) But I did test various cases manually directly on the phone.
Attached patch new patch with working tests (obsolete) (deleted) — — Splinter Review
This new patch slightly changes the statusbar javascript file to make it easily testable. Also it adds a simple mock file for l10N so that statusbar.js doesn't crash during tests.
Attachment #678984 - Attachment is obsolete: true
Attachment #679077 - Flags: review?(timdream+bugs)
Comment on attachment 679077 [details] [diff] [review] new patch with working tests r=me commit c2f9c11. There is only one small readability nit, you are welcome to ignore it. Thank you for writing Unit test too. https://github.com/mozilla-b2g/gaia/pull/6232
Attachment #679077 - Flags: review?(timdream+bugs) → review+
Attached patch patch (obsolete) (deleted) — — Splinter Review
Fixed the readability issue.
Attachment #679077 - Attachment is obsolete: true
Attachment #679223 - Flags: review?(timdream+bugs)
Attachment #679223 - Attachment description: https://github.com/mozilla-b2g/gaia/pull/6232 → patch
Comment on attachment 679223 [details] [diff] [review] patch You can just carry over the r+ :)
Attachment #679223 - Flags: review?(timdream+bugs) → review+
Attached patch patch (deleted) — — Splinter Review
for some reason (ie: this was my fault), the CSS file didn't get the name changes I made in the classes in the HTML file. updated the PR in https://github.com/mozilla-b2g/gaia/pull/6232
Attachment #679312 - Flags: review+
Comment on attachment 679223 [details] [diff] [review] patch this patch is obsolete
Attachment #679223 - Attachment is obsolete: true
Comment on attachment 679312 [details] [diff] [review] patch Vivien, I need this for Bug 802605. It was reviewed by :timdream already.
Attachment #679312 - Flags: feedback?(21)
Blocking a blocker. Blocking+.
blocking-basecamp: --- → +
Component: Gaia::Apps Management → General
Component: General → Gaia
Component: Gaia → Gaia::System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: