Closed Bug 809571 Opened 12 years ago Closed 12 years ago

Remove the libunwind stack walking code for ARM/Android

Categories

(Core :: Gecko Profiler, defect)

Product:
Core
Component:
Gecko Profiler
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla20
Tracking Flags:
Tracking Status
b2g18 ? ---

People

(Reporter: ehsan.akhgari, Assigned: BenWa)

References

Details

Attachments

(1 file, 1 obsolete file)

patch
(deleted), patch
ehsan.akhgari
: review+
Details | Diff | Splinter Review 
This code was first added in bug 734302, and with the stuff that Julian is working on, we will no longer need it.
Attached patch patch (obsolete) (deleted) — — Splinter Review 
Assignee: nobody → bgirard
Status: NEW → ASSIGNED

        Attachment #684476 -
        Flags: review?(ehsan)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch (deleted)
        — 
          — Splinter Review
      

    


  
This is a 3MB patch. Can't hg do rm more efficiently?

        Attachment #684476 -
        Attachment is obsolete: true

        Attachment #684476 -
        Flags: review?(ehsan)

        Attachment #684479 -
        Flags: review?(ehsan)

    
    

    
  
(In reply to Benoit Girard (:BenWa) from comment #2)
> Created attachment 684479 [details] [diff] [review]
> patch
> 
> This is a 3MB patch. Can't hg do rm more efficiently?

No, since it wants the patches that it generates to be compatible with the Unix patch program...

    
    

    
  
Comment on attachment 684479 [details] [diff] [review]
patch

Review of attachment 684479 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for doing this!

        Attachment #684479 -
        Flags: review?(ehsan) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/5a9706887c6e
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: