Closed Bug 809691 Opened 12 years ago Closed 12 years ago

Enable capitalization and suggestions for Calendar event title, location, and notes

Categories

(Firefox OS Graveyard :: Gaia::Calendar, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-basecamp:+)

VERIFIED FIXED
blocking-basecamp +

People

(Reporter: cpeterson, Assigned: cpeterson)

References

Details

Attachments

(1 file)

No description provided.
Attached patch inputmode=latin-prose.patch (deleted) — Splinter Review
Set inputmode="latin-prose" to enable initial capitalization and word suggestions for new Calendar events' title, location, and notes fields.
Attachment #679463 - Flags: review?(jlal)
Attachment #679463 - Flags: feedback?(dflanagan)
Looks good to me but can you please submit this as a github PR ?
Comment on attachment 679463 [details] [diff] [review] inputmode=latin-prose.patch Review of attachment 679463 [details] [diff] [review]: ----------------------------------------------------------------- feedback+, but note that we may later have to change inputmode to x-inputmode, per bug 796544
Attachment #679463 - Flags: feedback?(dflanagan) → feedback+
Sure, I just wanted to get Bugzilla r+ first. I didn't want to submit a PR with a commit message that said "r=lightsofapollo" _before_ you had even looked at the change. <:) https://github.com/mozilla-b2g/gaia/pull/6288
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment on attachment 679463 [details] [diff] [review] inputmode=latin-prose.patch r=lightsofapollo on github PR
Attachment #679463 - Flags: review?(jlal) → review+
Umm...didn't this need gaia approval? Also - I'm trying to figure out what this patch actually does. Can you clarify?
Comment on attachment 679463 [details] [diff] [review] inputmode=latin-prose.patch NOTE: If blocking-basecamp+ is set, just land it for now. [Approval Request Comment] Bug caused by (feature/regressing bug #): Not a regression User impact if declined: When entering new calendar events, the user will need to manually shift to capitalize the event's title, location, and notes. Android and iOS automatically capitalize these calendar fields. Testing completed: Tested locally Risk to taking this patch (and alternatives if risky): Low risk because it just adds an inputmode hint to an existing text input.
Attachment #679463 - Flags: approval-gaia-master?(21)
Keywords: verifyme
QA Contact: jsmith
Keywords: verifyme
The depends on bug has been used to close a blocking+ bug (bug 808921). So I guess this work is part of it. blocking-basecamp+. Also make sure to fix mounir's comment before landing.
blocking-basecamp: --- → +
I partially understand how to verify this for the capitalization piece, but not the suggestions - what behavior should I be seeing?
Keywords: verifyme
(In reply to Jason Smith [:jsmith] from comment #10) > I partially understand how to verify this for the capitalization piece, but > not the suggestions - what behavior should I be seeing? Jason, you first need to enable suggestions. Go to the phone's Settings app, Keyboard menu, and check the "Word suggestion" box. Then go back to the Calendar app. When I enter a new calendar event with the name "q", the keyboard suggests the words "quickly", "quality", and "quite".
Verified on 11/27 build.
Status: RESOLVED → VERIFIED
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: