Closed
Bug 809930
Opened 12 years ago
Closed 12 years ago
Make provider collection API more resilient to failures
Categories
(Firefox Health Report Graveyard :: Client: Desktop, defect)
Firefox Health Report Graveyard
Client: Desktop
Tracking
(firefox18 fixed, firefox19 fixed, firefox20 fixed)
RESOLVED
FIXED
Firefox 20
People
(Reporter: gps, Assigned: gps)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
rnewman
:
review+
akeybl
:
approval-mozilla-aurora+
akeybl
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Per discussion in bug 809644 we would like to make the collection API more resilient to failures. This tracks that.
I think the patch is pretty straight forward. The only thing I anticipate push back on is having a way to extract the failed providers from the collector. We may want to introduce more properties on the collector hold per-provider errors, etc.
Attachment #679726 -
Flags: review?(rnewman)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 679726 [details] [diff] [review]
More resilient error handling, v1
Review of attachment 679726 [details] [diff] [review]:
-----------------------------------------------------------------
::: services/metrics/collector.jsm
@@ +81,5 @@
> + } catch (ex) {
> + this._log.warn("Exception when calling " + name +
> + ".collectConstantMeasurements: " +
> + CommonUtils.exceptionStr(ex));
> + this.errors.push(ex);
How about having an errors map from name to errors? That would solve our desire to track which providers failed…
Happy to leave exploration of that for a follow-up.
Attachment #679726 -
Flags: review?(rnewman) → review+
|
Assignee | |
Comment 2•12 years ago
|
||
https://hg.mozilla.org/projects/larch/rev/0193dd08a8b7
With storage of errors in a map.
Assignee: nobody → gps
Status: NEW → ASSIGNED
Whiteboard: [fixed-in-larch]
|
|
||
Comment 3•12 years ago
|
||
Comment on attachment 679726 [details] [diff] [review]
More resilient error handling, v1
Bulk-setting approval flags for FHR landing for FxOS ADU ping (Bug 788894).
Attachment #679726 -
Flags: approval-mozilla-beta?
Attachment #679726 -
Flags: approval-mozilla-aurora?
|
|
||
Comment 4•12 years ago
|
||
Whiteboard: [fixed-in-larch]
|
|
||
Updated•12 years ago
|
Target Milestone: --- → mozilla20
|
||
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
|
||
Comment 6•12 years ago
|
||
Comment on attachment 679726 [details] [diff] [review]
More resilient error handling, v1
FHR for B2G ADU ping, won't be built/enabled for Mobile/Desktop.
Attachment #679726 -
Flags: approval-mozilla-beta?
Attachment #679726 -
Flags: approval-mozilla-beta+
Attachment #679726 -
Flags: approval-mozilla-aurora?
Attachment #679726 -
Flags: approval-mozilla-aurora+
|
|
||
Comment 7•12 years ago
|
||
|
||
Updated•12 years ago
|
Component: Metrics and Firefox Health Report → Client: Desktop
Flags: in-testsuite+
Product: Mozilla Services → Firefox Health Report
Target Milestone: mozilla20 → Firefox 20
|
||
Updated•6 years ago
|
Product: Firefox Health Report → Firefox Health Report Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•